Skip to content

feat: Android -Integrating Datadog SDK and Initialize RUM events..#197

Open
kalalmounesh wants to merge 4 commits into2U/developfrom
mounesh/LEARNER-10929
Open

feat: Android -Integrating Datadog SDK and Initialize RUM events..#197
kalalmounesh wants to merge 4 commits into2U/developfrom
mounesh/LEARNER-10929

Conversation

@kalalmounesh
Copy link

Datadog SDK integration and RUM events initialised

Copy link

@maheshchathani maheshchathani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All okay, but cross check anything missing related to target sdk 36, as you have updated it.

// Braze SDK Integration
implementation "com.braze:braze-segment-kotlin:1.4.2"
implementation "com.braze:android-sdk-ui:30.2.0"
// Datadog DSK Integration

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these comments

).flatten()
loadKoinModules(koinModules)
}
/**

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this comments

Rum.enable(rumConfig)
}

// -------------------- End Datadog --------------------

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove it


override fun onCreate() {
super.onCreate()
// android.util.Log.d(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove it

// )
// -------------------- Datadog Core --------------------

if (BuildConfig.DD_CLIENT_TOKEN.isNotEmpty() && BuildConfig.DD_APPLICATION_ID.isNotEmpty()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a suggestion: it would be better to move the Datadog-related code into a separate function and call that function from the onCreate() method in this class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants