fix: enable games xblock conditionally in component templates #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR attempts to move the games xblock enablement check from module load time to request time, allowing dynamic control via waffle flag. However, the implementation has critical bugs that prevent it from working correctly and introduce concurrency issues.
Changes:
- Removed module-level conditional addition of 'games' to COMPONENT_TYPES and BETA_COMPONENT_TYPES
- Added request-time conditional logic to enable games xblock within the get_component_templates function
- Modified beta component type checking to handle games dynamically
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
djoseph-apphelix
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is done to rearrange adding component by checking waffle-flag conditionally