feat: Added additional tracking log handeling by sending it to file#190
Open
srathod-apphelix wants to merge 1 commit intorelease-ulmofrom
Open
feat: Added additional tracking log handeling by sending it to file#190srathod-apphelix wants to merge 1 commit intorelease-ulmofrom
srathod-apphelix wants to merge 1 commit intorelease-ulmofrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a file-based logging destination for the tracking logger in the core logging configuration so tracking events can be written to a dedicated log file in addition to syslog.
Changes:
- Introduces a new
tracking_filehandler usinglogging.handlers.WatchedFileHandler. - Updates the
trackinglogger to emit to bothtracking(syslog) andtracking_file(file).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+88
to
+93
| 'tracking_file': { | ||
| 'level': 'DEBUG', | ||
| 'class': 'logging.handlers.WatchedFileHandler', | ||
| 'filename': '/edx/var/log/tracking/tracking_events.log', | ||
| 'formatter': 'raw', | ||
| }, |
Comment on lines
+90
to
+92
| 'class': 'logging.handlers.WatchedFileHandler', | ||
| 'filename': '/edx/var/log/tracking/tracking_events.log', | ||
| 'formatter': 'raw', |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe what this pull request changes, and why. Include implications for people using this change.
Design decisions and their rationales should be documented in the repo (docstring / ADR), per
OEP-19, and can be
linked here.
Useful information to include:
"Developer", and "Operator".
changes.
Supporting information
Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.
Testing instructions
Please provide detailed step-by-step instructions for testing this change.
Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.
Other information
Include anything else that will help reviewers and consumers understand the change.