fix: deleting snowflake cleanup script#1833
Conversation
There was a problem hiding this comment.
Pull request overview
Removes the deprecated snowflake-user-retirement-status-cleanup Jenkins job and its associated shell resource, and updates related documentation so the codebase no longer references or describes the retired cleanup process.
Changes:
- Deleted the Snowflake user retirement status cleanup job DSL definition.
- Removed the cleanup shell script resource and the seed-job registration/import for the job.
- Updated the
UserRetirementArchiverjob header comment to remove the now-obsolete Snowflake cleanup reference.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| devops/jobs/UserRetirementArchiver.groovy | Updates job documentation to remove references to the deleted Snowflake cleanup job. |
| dataeng/resources/snowflake-user-retirement-status-cleanup.sh | Removes the no-longer-needed cleanup script resource. |
| dataeng/jobs/createJobsNew.groovy | Removes import and taskMap entry so the seed job no longer creates the cleanup job. |
| dataeng/jobs/analytics/SnowflakeUserRetirementStatusCleanup.groovy | Removes the Jenkins Job DSL definition for the cleanup job. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
robrap
left a comment
robrap
left a comment
There was a problem hiding this comment.
Thanks @ktyagiapphelix2u. I'll take care of merging when I am ready, but this is all set.
Summary
Removing this job because it's no longer needed and has been failing since June 2024.
Why Remove It?
The job's purpose was to delete soft-deleted user retirement records from Snowflake that contained unredacted PII.
Now: We redact PII (redacted-XXX format) before it reaches Snowflake, so there's no unredacted PII to clean up. The cleanup job is obsolete.
What Changed
Deleted job definition and shell script
Removed from job creation pipeline
Deleted configuration file
Impact
Removes a failing job
No functional impact - PII is already redacted at the source
Soft-deleted records remain in Snowflake but contain only redacted values
Ticket Link - https://2u-internal.atlassian.net/browse/BOMS-293
Related PR
https://github.com/edx/analytics-config/pull/48