feat: improved local translation handling #195
Conversation
deborahgu
commented
Jan 29, 2026
deborahgu
commented
- pulls in any extra sources configured for credentials and edxapp
- technically I suppose there could be problems if they aren't in the environment but we are absolutely populating the environment in edx-internal
- added to the credentials docker file twice, because there's 2 different potential images where we build translations
- pulls in any extra sources configured for credentials and edxapp - technically I suppose there could be problems if they aren't in the environment but we are absolutely populating the environment in edx-internal - added to the credentials docker file twice, because there's 2 different potential images where we build translations
There was a problem hiding this comment.
Pull request overview
This PR enhances the translation handling system by introducing support for additional translation source repositories through the OPENEDX_ATLAS_EXTRA_SOURCES build argument, making it possible to pull translations from multiple sources beyond the primary repository.
Changes:
- Added
OPENEDX_ATLAS_EXTRA_SOURCESARG andATLAS_EXTRA_SOURCESENV variables to both edx-platform and credentials Dockerfiles - Applied changes to multiple Docker build stages (translations stage in edx-platform, base and dev stages in credentials)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| dockerfiles/edx-platform.Dockerfile | Added ARG and ENV declarations for extra translation sources in the translations build stage |
| dockerfiles/credentials.Dockerfile | Added ARG and ENV declarations for extra translation sources in both base and dev build stages |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ARG OPENEDX_ATLAS_EXTRA_SOURCES | ||
| ARG OPENEDX_TRANSLATIONS_VERSION | ||
| ARG OPENEDX_TRANSLATIONS_REPO | ||
| ENV ATLAS_EXTRA_SOURCES="--repository=$OPENEDX_ATLAS_EXTRA_SOURCES" |
There was a problem hiding this comment.
The ATLAS_EXTRA_SOURCES environment variable will be set to an invalid value when OPENEDX_ATLAS_EXTRA_SOURCES is empty or unset. The result would be "--repository=" which is an incomplete flag.
Consider using conditional logic to only set this environment variable when OPENEDX_ATLAS_EXTRA_SOURCES has a non-empty value, or ensure the downstream usage handles empty repository values gracefully.
| ENV TERM=xterm-256color | ||
| ENV DEBIAN_FRONTEND=noninteractive | ||
| ENV ATLAS_OPTIONS="--repository=$OPENEDX_TRANSLATIONS_REPO" | ||
| ENV ATLAS_EXTRA_SOURCES="--repository=$OPENEDX_ATLAS_EXTRA_SOURCES" |
There was a problem hiding this comment.
The ATLAS_EXTRA_SOURCES environment variable will be set to an invalid value when OPENEDX_ATLAS_EXTRA_SOURCES is empty or unset. The result would be "--repository=" which is an incomplete flag.
Consider using conditional logic to only set this environment variable when OPENEDX_ATLAS_EXTRA_SOURCES has a non-empty value, or ensure the downstream usage handles empty repository values gracefully.
| ENV ATLAS_EXTRA_SOURCES="--repository=$OPENEDX_ATLAS_EXTRA_SOURCES" | |
| ENV ATLAS_EXTRA_SOURCES="$OPENEDX_ATLAS_EXTRA_SOURCES" |
|
|
||
| ARG OPENEDX_ATLAS_EXTRA_SOURCES | ||
| ARG OPENEDX_TRANSLATIONS_REPO | ||
| ENV ATLAS_EXTRA_SOURCES="--repository=$OPENEDX_ATLAS_EXTRA_SOURCES" |
There was a problem hiding this comment.
The ATLAS_EXTRA_SOURCES environment variable will be set to an invalid value when OPENEDX_ATLAS_EXTRA_SOURCES is empty or unset. The result would be "--repository=" which is an incomplete flag.
Consider using conditional logic to only set this environment variable when OPENEDX_ATLAS_EXTRA_SOURCES has a non-empty value, or ensure the downstream usage handles empty repository values gracefully.
