Update sm141064.ngspice for spectre usage and multiplier MC fix #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor edits done by Hesham Omran * 1- Renamed subcircuits to avoid reusing the model name so that the model file is usable with spectre * 2- Used multi instead of m to avoid wrong Monte Carlo sim results as explained here: * https://www.linkedin.com/pulse/why-using-device-multiplier-can-make-your-monte-carlo-hesham-omran/ * Note: The multi fix is currently applied to transistors only Signed-off-by: omranh <[email protected]>
RTimothyEdwards
left a comment
RTimothyEdwards
left a comment
There was a problem hiding this comment.
Adding "multi" (although I prefer "mult") to all the devices is fine, but you can't go change all the device names or else you will break the entire PDK.
Author
|
What about renaming the model names instead of the subckt names? The target is to avoid using the same name twice to avoid circular dependency in spectre. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor edits done by Hesham Omran
Fixes #46