Skip to content

fix: unify number type handling and remove 'int' references across co… #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MakhBeth merged 1 commit into from
Dec 9, 2025
Merged

fix: unify number type handling and remove 'int' references across co… #611

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/vue-components/__tests__/IntegerValidation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { S } from "effect-app"
import { describe, expect, it } from "vitest"
import { generateInputStandardSchemaFromFieldMeta, generateMetaFromSchema } from "../src/components/OmegaForm/OmegaFormStuff"
import { generateInputStandardSchemaFromFieldMeta, generateMetaFromSchema, type NumberFieldMeta } from "../src/components/OmegaForm/OmegaFormStuff"

// mock German translations
const germanTranslations: Record<string, string> = {
Expand All @@ -20,15 +20,16 @@ const mockTrans = (id: string, values?: Record<string, any>) => {
}

describe("Integer validation with German translations", () => {
it("should generate int metadata for S.Int fields", () => {
it("should generate number metadata with int refinement for S.Int fields", () => {
const TestSchema = S.Struct({
value: S.Int
})

const { meta } = generateMetaFromSchema(TestSchema)
console.log("Meta:", JSON.stringify(meta, null, 2))

expect(meta.value?.type).toBe("int")
expect(meta.value?.type).toBe("number")
expect((meta.value as NumberFieldMeta).refinement).toBe("int")
})

it("should show German error for decimal values", async () => {
Expand Down