Skip to content

Support typescript-eslint 8+ #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igorkamyshev merged 4 commits into from
Aug 12, 2025
Merged

Support typescript-eslint 8+ #170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
38dd841
bump deps
7rulnik Aug 11, 2025
de11e78
Initial test migration
7rulnik Aug 11, 2025
87c26f0
fix suggestions
7rulnik Aug 11, 2025
4f30f31
Simplify RuleTester options
7rulnik Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,13 @@
},
"devDependencies": {
"@types/react": "^17.0.37",
"@typescript-eslint/parser": "^6.0.0",
"@typescript-eslint/rule-tester": "^6.0.0",
"@typescript-eslint/utils": "^6.0.0",
"@typescript-eslint/parser": "^8.0.0",
"@typescript-eslint/rule-tester": "^8.0.0",
"@typescript-eslint/utils": "^8.0.0",
"clean-publish": "^3.2.0",
"effector": "^23",
"effector-react": "^23",
"eslint": "^8.0.0",
"eslint": "^8.57.0",
"glob": "^8.0.3",
"jest": "^29.0.0",
"nano-staged": "^0.5.0",
Expand All @@ -45,7 +45,7 @@
},
"peerDependencies": {
"effector": "^23",
"eslint": "7 || 8"
"eslint": "^8.57.0 || ^9.0.0"
Copy link
Contributor Author

@7rulnik 7rulnik Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably good idea to test again both of eslint versions

Copy link
Contributor Author

@7rulnik 7rulnik Aug 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the idea is a good one, but I'm not sure how to do it correctly right now because RuleTester in eslint v9 is hardcoded to flat config option. As I understand, it's possible to patch this.linter in RuleTester instance, but I am not so sure about it. The right wat probably just drop eslint 8 and support flat config. We can extract this into a separate issue.

Basically, I took support range from @typescript-eslint/parser. It will require MAJOR release of this plugin

},
"dependencies": {
"prettier": "^2.3.2"
Expand Down
Loading