Skip to content

Conversation

mattisboeckle
Copy link
Contributor

@mattisboeckle mattisboeckle commented Mar 14, 2025

We are running into problems where the versions used for development and for the CI are differing so much that we sometimes write code in development that is invalid in the CI. (See #877)

I propose upping the Version to 18, which seems to be the Ubuntu standard

Edit: the latest release is 20.1.0, so we are also not in unstable territory

@jiribenes
Copy link
Contributor

jiribenes commented Mar 14, 2025

Note that this needs to be coordinated as it also requires changes at least:

  1. on the website

  2. in the autorelease CI,

    - name: Install Chez Scheme, LLVM & libuv
    run: sudo apt-get install -y chezscheme llvm-15 libuv1-dev

  3. in the config,

    default = Some(sys.env.getOrElse("EFFEKT_LLVM_VERSION", "15")),

  4. and in the runner!

    lazy val llcCmd = discoverExecutable(List("llc", "llc-15", "llc-16"), List("--version"))

plus in the packaging in effekt-nix (but I can take care of that part) for the community build(s)

@marvinborner
Copy link
Member

Are we sure we want to make version 18 a requirement? The default version in current Debian (which is probably which most people install) is still below 18 (or even 15, see here).

Either way, we'd also need to sync this change with the plots ci (which uses the default Ubuntu version)

@jiribenes
Copy link
Contributor

FWIW, I'm fine with pushing Debian users into using the official apt packages via https://apt.llvm.org/

@mattisboeckle
Copy link
Contributor Author

Changed the remaining locations I could find. I think we should rebase this on top of #888.

@jiribenes
Copy link
Contributor

We still need to update the website in sync as it mentions the version requirements: https://github.com/effekt-lang/effekt-website/blob/d2f0fee403ef48777465f48f0998a42cd35ed0e9/contributing.md?plain=1#L34

@mattisboeckle
Copy link
Contributor Author

effekt-website also has a PR now.

effekt-lang/effekt-website#84

Copy link
Contributor

@jiribenes jiribenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@jiribenes jiribenes merged commit 81fc25d into master Mar 28, 2025
2 checks passed
@jiribenes jiribenes deleted the upgrade-llvm-version branch March 28, 2025 14:58
lenakaeufel pushed a commit to lenakaeufel/effekt that referenced this pull request May 1, 2025
We are running into problems where the versions used for development and
for the CI are differing so much that we sometimes write code in
development that is invalid in the CI. (See effekt-lang#877)

I propose upping the Version to 18, which seems to be the Ubuntu
standard

Edit: the latest release is 20.1.0, so we are also not in unstable
territory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants