-
Notifications
You must be signed in to change notification settings - Fork 38
Bump to llvm version 18 in CI #887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Note that this needs to be coordinated as it also requires changes at least:
plus in the packaging in effekt-nix (but I can take care of that part) for the community build(s) |
Are we sure we want to make version 18 a requirement? The default version in current Debian (which is probably which most people install) is still below 18 (or even 15, see here). Either way, we'd also need to sync this change with the plots ci (which uses the default Ubuntu version) |
FWIW, I'm fine with pushing Debian users into using the official apt packages via https://apt.llvm.org/ |
Changed the remaining locations I could find. I think we should rebase this on top of #888. |
265a091
to
6f6bc85
Compare
We still need to update the website in sync as it mentions the version requirements: https://github.com/effekt-lang/effekt-website/blob/d2f0fee403ef48777465f48f0998a42cd35ed0e9/contributing.md?plain=1#L34 |
effekt-website also has a PR now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We are running into problems where the versions used for development and for the CI are differing so much that we sometimes write code in development that is invalid in the CI. (See effekt-lang#877) I propose upping the Version to 18, which seems to be the Ubuntu standard Edit: the latest release is 20.1.0, so we are also not in unstable territory
We are running into problems where the versions used for development and for the CI are differing so much that we sometimes write code in development that is invalid in the CI. (See #877)
I propose upping the Version to 18, which seems to be the Ubuntu standard
Edit: the latest release is 20.1.0, so we are also not in unstable territory