Fix the start version in bad-commit #387
Conversation
Signed-off-by: Arnaud M. <[email protected]>
WalkthroughA README documentation update replaces an ambiguous placeholder in step 3 with a concrete commit hash (63e1df85cb135e97e562c8f15f883bb4e5137e8c). No functional or behavioral changes; the instruction sequence remains structurally identical. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| 1. Start `git bisect`. | ||
| 2. Usually the HEAD is "bad", as it is in this exercise. Use `git bisect bad` to indicate it. | ||
| 3. Usually some old version will be good. In this exercise, the start version is. Use `git bisect good <commit-ish>` to indicate it. | ||
| 3. Usually some old version will be good. In this exercise, the start version is `63e1df85cb135e97e562c8f15f883bb4e5137e8c`. Use `git bisect good <commit-ish>` to indicate it. |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify the commit hash exists and inspect its state
# Check if the commit exists in the repository
git rev-parse 63e1df85cb135e97e562c8f15f883bb4e5137e8c > /dev/null 2>&1
if [ $? -eq 0 ]; then
echo "✓ Commit hash is valid"
else
echo "✗ Commit hash not found"
exit 1
fi
# Check if badfile exists at this commit
git show 63e1df85cb135e97e562c8f15f883bb4e5137e8c:badfile > /dev/null 2>&1
if [ $? -eq 0 ]; then
echo "✗ WARNING: badfile exists at this commit (expected 'good' state)"
else
echo "✓ badfile does not exist at this commit (expected 'good' state)"
fi
# Display commit info for context
echo ""
echo "Commit details:"
git show --oneline -s 63e1df85cb135e97e562c8f15f883bb4e5137e8cRepository: eficode-academy/git-katas
Length of output: 424
🏁 Script executed:
#!/bin/bash
# More direct verification of the commit hash
echo "=== Checking commit existence in git log ==="
git log --oneline --all | grep "63e1df85cb135e97e562c8f15f883bb4e5137e8c" || echo "Not found in git log"
echo ""
echo "=== Checking with git rev-list ==="
git rev-list --all | grep "63e1df85cb135e97e562c8f15f883bb4e5137e8c" || echo "Not found in git rev-list"
echo ""
echo "=== Checking repository structure ==="
git log --oneline --max-count=20
echo ""
echo "=== Reading the README.md file to see context ==="
cat bad-commit/README.md | head -25Repository: eficode-academy/git-katas
Length of output: 1442
The commit hash 63e1df85cb135e97e562c8f15f883bb4e5137e8c does not exist in the repository.
The verification shows this commit is not present in the git history (git log and git rev-list do not find it). Users cannot complete step 3 of the exercise because the commit reference is invalid. Provide a valid commit hash from the repository's actual history as the starting "good" state for the bisect exercise.
🤖 Prompt for AI Agents
In bad-commit/README.md around line 20, the specified "good" commit hash
63e1df85cb135e97e562c8f15f883bb4e5137e8c does not exist in the repository;
replace it with a valid commit from this repo by running git log or git rev-list
to find an appropriate earlier good commit and update the line to reference that
actual commit hash, preserving the instruction to use git bisect good
<commit-ish>. Ensure the new hash is present in the repository history and
matches the format used elsewhere in the README.
1 participant
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.