Skip to content

Conversation

@michaelortmann
Copy link
Member

Found by: michaelortmann
Patch by: michaelortmann
Fixes:

One-line summary:
Copy module text files

Additional description (if needed):

Test cases demonstrating functionality (if applicable):
Tested with #1467, were we copy src/mod/webui.mod/text/webui.html to $DEST/text

Michael Ortmann and others added 2 commits May 7, 2024 17:50
@vanosg
Copy link
Member

vanosg commented Jul 30, 2024

Can you provide context on why we are copying these files?

@michaelortmann
Copy link
Member Author

Can you provide context on why we are copying these files?

#1467 (webui.mod) will make use of it. but i think its a good idea in general, to copy module text/ files (if they dont exist yet).

@michaelortmann
Copy link
Member Author

michaelortmann commented Oct 24, 2025

currently there is no way for any module to create directories or copy files via module Makefile because module Makefiles do not have install targets defined

we cannot add/run a new install target to the module Makefile(s) because it would break any other module that doesnt define such target when the core Makefile tries to run such new target for each module

but how does eggdrop handle cases like filesys.mod? it does so in core Makefile via install target install-filesys

so the current state of webui.mod (#1467) will do like filesys.mod, see: 7680021#diff-b48650cabc0f502b52865f525765f2d688198f06e0ffb5456c76fabab7f2bfb2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants