Fix share.mod feature negotiation between bots#1629
Open
michaelortmann wants to merge 13 commits intoeggheads:developfrom
Open
Fix share.mod feature negotiation between bots#1629michaelortmann wants to merge 13 commits intoeggheads:developfrom
michaelortmann wants to merge 13 commits intoeggheads:developfrom
Conversation
Merged to resolve conflicts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by: michaelortmann
Patch by: michaelortmann
Fixes:
One-line summary:
Fix
share.moduser file feature parser/checkerAdditional description (if needed):
Since eggdrop 1.8.1 the
share.modfeature negotiation between bots is broken.Here we removed what looked like a surplus white space :
afdd3a5#diff-b39a75736674964b2c9de0f99a01ea3084f0a7d6288184e7dc98fe7ee075135e
But the bots parser/checker depends on that very trailing space and drops the last feature, if the space is not seen
So, this bug disables the last
share.modfeature negotiated.For
.console +ghthe lines[03:21:30] {b<-BotB} uy exempts invites compressand
[03:21:30] {b->BotB} feats exempts invites compressare associated.
For a buggy bot, the last line would be without the last word:
[04:13:06] {b->BotB} feats exempts invitesIf the last feature, like in this example is
compress, then this bug disables compression for user file sharing, rendering the following config a noop:This PR fixes the parser.
Additionally, to be compatible to buggy bots (bots that have the buggy feature parser but at the same time send all feature flags), the trailing white space is re-added.
After adding the trailing whitespace, it didnt work with my eggdrop 1.9.5 testbot. Turns out, also the bug fixed with #1506 broke userfile sharing. So, fixing / testing is only possible for bots not effected by the bug fixed with #1506. eggdrop versions
>= 1090200and<= 1090504.Test cases demonstrating functionality (if applicable):
Link 2 share bots with
Test 1:Active and passive share bots are the version equal to this PR
Result:
Test2:
Active share bot is the version equal to this PR, passive share bot is version after merge of #1506 which equals 6bc6560
Result: