Skip to content

Conversation

@michaelortmann
Copy link
Member

@michaelortmann michaelortmann commented Feb 12, 2025

Found by: michaelortmann
Patch by: michaelortmann
Fixes:

One-line summary:
Sleep less - improve responsiveness user experience

Additional description (if needed):
Lower amount of time we sleep() in some exit/quit situations.
I would favor to remove all such sleeps ;)
But because of historical reasons, lets just lower the amount here.
I checked ircii, irssi and weechat and there is no single sleep in them longer than 2 secs.
mirc removed any sleep a long time ago: https://forums.mirc.com/ubbthreads.php/topics/251851/exit-and-quit-message
Also i argue: why do we sleep in some situations, when in others we dont need to, like .jump does not sleep:

.jump 127.0.0.1
18:04:33.309994 write(8, "QUIT :changing servers\n", 23) = 23
18:04:33.310534 close(8)                = 0

Test cases demonstrating functionality (if applicable):
2 sleeps were modified, so i checked both situations:

  1. /msg <bot> die <passwd>
  2. kill <pid_of_bot>

@vanosg vanosg added this to the v1.10.2 milestone Jun 14, 2025
@thommey
Copy link
Member

thommey commented Nov 30, 2025

The code is fine, the principle of the thing is up to @vanosg

@vanosg
Copy link
Member

vanosg commented Nov 30, 2025

Let's drop the 3 second to 1 second to match the msg command and not adjust the msg command 1s to .5s.

@michaelortmann
Copy link
Member Author

done. ready for review again.

Copy link
Member

@thommey thommey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vanosg vanosg merged commit e535d43 into eggheads:develop Dec 24, 2025
26 checks passed
@michaelortmann michaelortmann deleted the sleep.less branch December 24, 2025 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants