Merged
Conversation
Member
|
The code is fine, the principle of the thing is up to @vanosg |
Member
|
Let's drop the 3 second to 1 second to match the msg command and not adjust the msg command 1s to .5s. |
Member
Author
|
done. ready for review again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by: michaelortmann
Patch by: michaelortmann
Fixes:
One-line summary:
Sleep less - improve responsiveness user experience
Additional description (if needed):
Lower amount of time we sleep() in some exit/quit situations.
I would favor to remove all such sleeps ;)
But because of historical reasons, lets just lower the amount here.
I checked ircii, irssi and weechat and there is no single sleep in them longer than 2 secs.
mirc removed any sleep a long time ago: https://forums.mirc.com/ubbthreads.php/topics/251851/exit-and-quit-message
Also i argue: why do we sleep in some situations, when in others we dont need to, like
.jumpdoes not sleep:Test cases demonstrating functionality (if applicable):
2 sleeps were modified, so i checked both situations:
/msg <bot> die <passwd>kill <pid_of_bot>