fix(ci): reorder release workflow to run build after version bump#5805
fix(ci): reorder release workflow to run build after version bump#5805
Conversation
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe release workflow step order is changed so the "Run build" step executes after version bumping and git push/tag operations; additionally, Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer
participant GH as GitHub Actions
participant Git as Git (repo)
participant Build as Build step
participant Reg as Registry/Publish
Dev->>Git: push release commit & tag
Git->>GH: trigger release workflow
GH->>Git: run version bump & git push (update tags)
GH->>Build: run build step (moved here)
Build-->>GH: build artifacts
GH->>Reg: publish artifacts
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying egg with
|
| Latest commit: |
860feac
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4a519675.egg-cci.pages.dev |
| Branch Preview URL: | https://fix-release-workflow-order.egg-cci.pages.dev |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #5805 +/- ##
=======================================
Coverage 85.22% 85.22%
=======================================
Files 650 650
Lines 12518 12518
Branches 1436 1436
=======================================
Hits 10669 10669
Misses 1729 1729
Partials 120 120 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Deploying egg-v3 with
|
| Latest commit: |
860feac
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f6a8b00b.egg-v3.pages.dev |
| Branch Preview URL: | https://fix-release-workflow-order.egg-v3.pages.dev |
There was a problem hiding this comment.
Pull request overview
This PR fixes a CI/CD workflow failure by reordering the build step in the release workflow. The issue occurs because tsdown with devExports: true modifies package.json exports during the build process, causing the git working directory to become dirty. Since scripts/version.js requires a clean git state before running, the build must happen after the version bump and git push operations.
Changes:
- Move
pnpm buildstep from before version bump (lines 78-79) to after version bump and git push (lines 110-111) - Build output is only needed for the publish step, which already uses
--no-git-checksflag
tsdown with devExports modifies package.json exports during build, causing git working directory to be dirty when version bump checks. Moving build after version bump ensures a clean git state for the version script. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The prepublishOnly script runs tsdown individually during pnpm -r publish, but tsdown workspace mode fails after devExports has already modified package.json files. The root pnpm build already builds all packages including logger, so prepublishOnly is unnecessary. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
dd4e0ba to
860feac
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Summary
pnpm buildstep after version bump in the release workflowdevExports: truemodifiespackage.jsonexports during build, causingscripts/version.jsto fail with "Git working directory is not clean"--no-git-checksTest plan
🤖 Generated with Claude Code
Summary by CodeRabbit