Skip to content

fix(ci): reorder release workflow to run build after version bump#5805

Merged
killagu merged 2 commits intonextfrom
fix/release-workflow-order
Feb 24, 2026
Merged

fix(ci): reorder release workflow to run build after version bump#5805
killagu merged 2 commits intonextfrom
fix/release-workflow-order

Conversation

@killagu
Copy link
Copy Markdown
Contributor

@killagu killagu commented Feb 24, 2026

Summary

  • Move pnpm build step after version bump in the release workflow
  • tsdown with devExports: true modifies package.json exports during build, causing scripts/version.js to fail with "Git working directory is not clean"
  • Build output is only needed for the publish step, which already uses --no-git-checks

Test plan

  • Trigger Manual Release workflow with dry_run to verify version bump succeeds
  • Trigger Manual Release workflow to verify full release flow works

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Reordered release pipeline so the build now runs after version bump and after pushing changes/tags, adjusting the release sequence.
    • Removed an obsolete pre-publish script from the logger package to simplify package scripts.

Copilot AI review requested due to automatic review settings February 24, 2026 09:23
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dd4e0ba and 860feac.

📒 Files selected for processing (2)
  • .github/workflows/release.yml
  • packages/logger/package.json
💤 Files with no reviewable changes (1)
  • packages/logger/package.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/release.yml

📝 Walkthrough

Walkthrough

The release workflow step order is changed so the "Run build" step executes after version bumping and git push/tag operations; additionally, prepublishOnly was removed from packages/logger/package.json.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow Sequencing
.github/workflows/release.yml
Moved the "Run build" step to occur after version bump, git push and tag steps, altering workflow step order during release.
Logger package manifest
packages/logger/package.json
Removed the prepublishOnly npm script from the logger package's package.json.

Sequence Diagram(s)

sequenceDiagram
    participant Dev as Developer
    participant GH as GitHub Actions
    participant Git as Git (repo)
    participant Build as Build step
    participant Reg as Registry/Publish

    Dev->>Git: push release commit & tag
    Git->>GH: trigger release workflow
    GH->>Git: run version bump & git push (update tags)
    GH->>Build: run build step (moved here)
    Build-->>GH: build artifacts
    GH->>Reg: publish artifacts
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I hopped through lines of YAML neat,
Moved the build to a later beat,
A tag, a push, then build's bright song,
Logger sheds a script and hops along.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title clearly and specifically describes the main change: reordering the release workflow to run the build step after the version bump step.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/release-workflow-order

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Feb 24, 2026

Deploying egg with  Cloudflare Pages  Cloudflare Pages

Latest commit: 860feac
Status: ✅  Deploy successful!
Preview URL: https://4a519675.egg-cci.pages.dev
Branch Preview URL: https://fix-release-workflow-order.egg-cci.pages.dev

View logs

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.22%. Comparing base (b1fdf2e) to head (860feac).
⚠️ Report is 3 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #5805   +/-   ##
=======================================
  Coverage   85.22%   85.22%           
=======================================
  Files         650      650           
  Lines       12518    12518           
  Branches     1436     1436           
=======================================
  Hits        10669    10669           
  Misses       1729     1729           
  Partials      120      120           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Feb 24, 2026

Deploying egg-v3 with  Cloudflare Pages  Cloudflare Pages

Latest commit: 860feac
Status: ✅  Deploy successful!
Preview URL: https://f6a8b00b.egg-v3.pages.dev
Branch Preview URL: https://fix-release-workflow-order.egg-v3.pages.dev

View logs

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a CI/CD workflow failure by reordering the build step in the release workflow. The issue occurs because tsdown with devExports: true modifies package.json exports during the build process, causing the git working directory to become dirty. Since scripts/version.js requires a clean git state before running, the build must happen after the version bump and git push operations.

Changes:

  • Move pnpm build step from before version bump (lines 78-79) to after version bump and git push (lines 110-111)
  • Build output is only needed for the publish step, which already uses --no-git-checks flag

killagu and others added 2 commits February 24, 2026 17:42
tsdown with devExports modifies package.json exports during build,
causing git working directory to be dirty when version bump checks.
Moving build after version bump ensures a clean git state for the
version script.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The prepublishOnly script runs tsdown individually during pnpm -r publish,
but tsdown workspace mode fails after devExports has already modified
package.json files. The root pnpm build already builds all packages
including logger, so prepublishOnly is unnecessary.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@killagu killagu force-pushed the fix/release-workflow-order branch from dd4e0ba to 860feac Compare February 24, 2026 09:43
@socket-security
Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​types/​mocha@​10.0.101001007780100

View full report

@killagu killagu merged commit 35ce8c0 into next Feb 24, 2026
47 of 52 checks passed
@killagu killagu deleted the fix/release-workflow-order branch February 24, 2026 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants