Skip to content

fix(ci): remove test sharding to reduce runner usage#5845

Merged
killagu merged 1 commit intonextfrom
merge_ci_action
Mar 28, 2026
Merged

fix(ci): remove test sharding to reduce runner usage#5845
killagu merged 1 commit intonextfrom
merge_ci_action

Conversation

@killagu
Copy link
Copy Markdown
Contributor

@killagu killagu commented Mar 28, 2026

Summary

  • Remove shardIndex/shardTotal matrix from test and test-egg-bin jobs
  • Each platform/node combo now runs all tests in a single job instead of splitting into 3 shards
  • Total CI jobs reduced from 37 to 14 (~62% reduction)

Test plan

  • CI passes on all platforms (ubuntu, macos, windows)
  • egg-bin tests pass without CI_NODE_INDEX/CI_NODE_TOTAL

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Streamlined CI workflow by removing test sharding configuration from the testing infrastructure.

Merge shard 1/2/3 into a single job per platform/node combination,
reducing total CI jobs from 37 to 14.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings March 28, 2026 04:50
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 28, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0614b141-71e8-41ab-a8e1-5224a9a27511

📥 Commits

Reviewing files that changed from the base of the PR and between 53bd879 and fde6c15.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

📝 Walkthrough

Walkthrough

The CI workflow has been simplified by removing test sharding configuration. The matrix definitions for shard indices, job name placeholders, concurrency group references, and environment variable injections have been eliminated. Tests now execute without shard parameters.

Changes

Cohort / File(s) Summary
CI Workflow Simplification
.github/workflows/ci.yml
Removed test sharding infrastructure: eliminated matrix.shardIndex and matrix.shardTotal entries from both test and test-egg-bin jobs, stripped shard placeholders from job names and concurrency groups, removed pnpm run ci shard argument passing, and deleted CI_NODE_INDEX/CI_NODE_TOTAL environment variable injections.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 No more shards to split the tests in two,
The workflow runs now clean and through,
One unified path instead of many,
Simpler CI means faster any,
Hop-hooray for this config relief! 🎉

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing test sharding from the CI workflow to reduce runner usage.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch merge_ci_action

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying egg with  Cloudflare Pages  Cloudflare Pages

Latest commit: fde6c15
Status: ✅  Deploy successful!
Preview URL: https://109a7716.egg-cci.pages.dev
Branch Preview URL: https://merge-ci-action.egg-cci.pages.dev

View logs

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies CI execution by removing test sharding so that each OS/Node combination runs the full test suite in a single job, reducing total runner/job usage in the monorepo’s GitHub Actions pipeline.

Changes:

  • Removed shardIndex/shardTotal matrices from test and test-egg-bin jobs.
  • Dropped Vitest --shard= invocation from the main test job.
  • Removed CI_NODE_INDEX/CI_NODE_TOTAL env wiring from the egg-bin CI job and updated job naming/concurrency keys accordingly.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.36%. Comparing base (53bd879) to head (fde6c15).
⚠️ Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #5845      +/-   ##
==========================================
- Coverage   85.63%   85.36%   -0.27%     
==========================================
  Files         665      665              
  Lines       13004    13004              
  Branches     1495     1495              
==========================================
- Hits        11136    11101      -35     
- Misses       1744     1775      +31     
- Partials      124      128       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying egg-v3 with  Cloudflare Pages  Cloudflare Pages

Latest commit: fde6c15
Status: ✅  Deploy successful!
Preview URL: https://533ed173.egg-v3.pages.dev
Branch Preview URL: https://merge-ci-action.egg-v3.pages.dev

View logs

@socket-security
Copy link
Copy Markdown

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
Obfuscated code: npm entities is 91.0% likely obfuscated

Confidence: 0.91

Location: Package overview

From: pnpm-lock.yamlnpm/cheerio@1.1.2npm/entities@4.5.0

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/entities@4.5.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
Obfuscated code: npm entities is 91.0% likely obfuscated

Confidence: 0.91

Location: Package overview

From: pnpm-lock.yamlnpm/cheerio@1.1.2npm/entities@6.0.1

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/entities@6.0.1. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
Obfuscated code: npm ioredis is 96.0% likely obfuscated

Confidence: 0.96

Location: Package overview

From: plugins/redis/package.jsonnpm/ioredis@5.8.1

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/ioredis@5.8.1. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
Obfuscated code: npm js-beautify is 100.0% likely obfuscated

Confidence: 1.00

Location: Package overview

From: pnpm-lock.yamlnpm/js-beautify@1.15.4

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/js-beautify@1.15.4. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
Obfuscated code: npm markdown-it is 91.0% likely obfuscated

Confidence: 0.91

Location: Package overview

From: pnpm-lock.yamlnpm/markdown-it@14.1.0

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/markdown-it@14.1.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@killagu killagu merged commit 0dc5dfb into next Mar 28, 2026
44 of 48 checks passed
@killagu killagu deleted the merge_ci_action branch March 28, 2026 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants