fix(koa): use non-null assertion for ctxStorage instanceof check in tests#5854
Closed
Copilot wants to merge 1 commit intofeat/snapshot-koafrom
Closed
fix(koa): use non-null assertion for ctxStorage instanceof check in tests#5854Copilot wants to merge 1 commit intofeat/snapshot-koafrom
Copilot wants to merge 1 commit intofeat/snapshot-koafrom
Conversation
3 tasks
Copilot
AI
changed the title
[WIP] Defer AsyncLocalStorage creation for V8 startup snapshot support
fix(koa): use non-null assertion for ctxStorage instanceof check in tests
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snapshot test assertions against
ctxStoragerequired narrowing the nullableAsyncLocalStorage<Context> | nulltype before callinginstanceof. Without the non-null assertion, TypeScript rejects the comparison sincenullis not an instance of anything.Changes
packages/koa/test/application/snapshot.test.ts— Add!non-null assertions onctxStorageaccesses used ininstanceof AsyncLocalStoragechecks, matching the deliberate nullable typing introduced in the parent snapshot PR.