Skip to content

Conversation

@oflatt
Copy link
Member

@oflatt oflatt commented Jan 6, 2026

No description provided.

Copilot AI review requested due to automatic review settings January 6, 2026 12:43
@oflatt oflatt requested a review from a team as a code owner January 6, 2026 12:43
@oflatt oflatt requested review from ezrosent and removed request for a team January 6, 2026 12:43
@oflatt oflatt marked this pull request as draft January 6, 2026 12:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new egraph-detailed-stats command to the egglog-experimental library for retrieving detailed statistics about the e-graph state.

  • Adds a new stats module with the EgraphDetailedStats command implementation
  • Registers the egraph-detailed-stats command in the experimental e-graph
  • Includes test coverage with a dedicated test file and integration into an existing comprehensive test

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/lib.rs Imports the new stats module and registers the egraph-detailed-stats command in the experimental e-graph setup
tests/web-demo/detailed-stats.egg New test file demonstrating the egraph-detailed-stats command with a simple Math datatype example
tests/herbie-rational.egg Adds a call to egraph-detailed-stats in an existing comprehensive test case to verify it works in a real-world scenario

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +37 to +38
mod stats;
pub use stats::*;
Copy link

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code references a stats module and uses EgraphDetailedStats struct, but the src/stats.rs file is not included in this PR and does not exist in the repository. This will cause a compilation error. The implementation of the stats module containing the EgraphDetailedStats command needs to be added.

Copilot uses AI. Check for mistakes.
(run-schedule (saturate (run)))

; Get detailed statistics
(egraph-detailed-stats)
Copy link

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test for the new egraph-detailed-stats command doesn't include any assertions to verify the command's output or behavior. Consider adding checks to validate that the command executes successfully and potentially verify aspects of the returned statistics, similar to how get-size! is validated in other tests.

Copilot uses AI. Check for mistakes.
@cowardsa
Copy link

cowardsa commented Jan 6, 2026

Ooops CI very unhappy haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants