Upgrade egglog version #258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrades the egglog version to use the new parser as well as the experimental repo.
saulshanabrook
added a commit
to saulshanabrook/egg-smol
that referenced
this pull request
Feb 17, 2025
This PR makes public the fields on the egglog span so that we can access them from the Python bindings. In Python, I have been generally converting to/from egglog sructs by creating a corresponding Python class and copying all of their fields. To do so , it has to be public. I also use the debug formatting to allow pretty printing in Python as the rust struct. See egraphs-good/egglog-python#258 for the corresponding PR on the Python side.
saulshanabrook
added a commit
to saulshanabrook/egg-smol
that referenced
this pull request
Feb 17, 2025
This PR makes public the fields on the egglog span so that we can access them from the Python bindings. In Python, I have been generally converting to/from egglog sructs by creating a corresponding Python class and copying all of their fields. To do so , it has to be public. I also use the debug formatting to allow pretty printing in Python as the rust struct. See egraphs-good/egglog-python#258 for the corresponding PR on the Python side.
CodSpeed Performance ReportMerging #258 will improve performances by ×57Comparing Summary
Benchmarks breakdown
|
saulshanabrook
force-pushed
the
upgrade-egglog
branch
from
dd45074 to
e58bd2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades the egglog version to use the new parser as well as the experimental repo.