-
Notifications
You must be signed in to change notification settings - Fork 13
Bump Egglog version #335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Egglog version #335
Conversation
Bump egglog version which changes running commands to return structured output and adds fields on the serialized e-graph to show if functions were omitted.
|
@actions-user changelog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR bumps the egglog version, updating the dependencies to use the main branch versions and modifying the Python bindings to work with structured command outputs instead of string outputs.
- Updates
run_programmethod to return structuredCommandOutputobjects instead of strings - Adds new fields to
SerializedEGraphfor tracking truncated and discarded functions - Refactors command handling to use structured output types
Reviewed Changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/serialize.rs | Adds new fields for tracking function truncation/discard status |
| src/lib.rs | Registers new Python classes for structured command outputs |
| src/egraph.rs | Updates run_program to return structured outputs and removes legacy report methods |
| src/conversions.rs | Implements new command output types and updates function command naming |
| python/tests/test_py_object_sort.py | Updates tests to use new structured output format |
| python/tests/test_bindings.py | Updates tests to use new structured output format |
| python/egglog/exp/array_api.py | Removes type ignore comment |
| python/egglog/egraph_state.py | Updates function command reference |
| python/egglog/egraph.py | Refactors to use structured command outputs |
| python/egglog/bindings.pyi | Updates type definitions for new structured outputs |
| docs/changelog.md | Documents the version bump |
| Cargo.toml | Updates dependency versions to main branch |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
671a431 to
44f6214
Compare
CodSpeed Instrumentation Performance ReportMerging #335 will not alter performanceComparing Summary
|
Bump egglog version which changes running commands to return structured output and adds fields on the serialized e-graph to show if functions were omitted.
Follow up PRs will expose this functionality at the high level.