Skip to content

Conversation

@saulshanabrook
Copy link
Member

Bump egglog version which changes running commands to return structured output and adds fields on the serialized e-graph to show if functions were omitted.

Follow up PRs will expose this functionality at the high level.

Bump egglog version which changes running commands to return structured
output and adds fields on the serialized e-graph to show if functions
were omitted.
@saulshanabrook
Copy link
Member Author

@actions-user changelog

github-actions bot pushed a commit that referenced this pull request Sep 1, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps the egglog version, updating the dependencies to use the main branch versions and modifying the Python bindings to work with structured command outputs instead of string outputs.

  • Updates run_program method to return structured CommandOutput objects instead of strings
  • Adds new fields to SerializedEGraph for tracking truncated and discarded functions
  • Refactors command handling to use structured output types

Reviewed Changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/serialize.rs Adds new fields for tracking function truncation/discard status
src/lib.rs Registers new Python classes for structured command outputs
src/egraph.rs Updates run_program to return structured outputs and removes legacy report methods
src/conversions.rs Implements new command output types and updates function command naming
python/tests/test_py_object_sort.py Updates tests to use new structured output format
python/tests/test_bindings.py Updates tests to use new structured output format
python/egglog/exp/array_api.py Removes type ignore comment
python/egglog/egraph_state.py Updates function command reference
python/egglog/egraph.py Refactors to use structured command outputs
python/egglog/bindings.pyi Updates type definitions for new structured outputs
docs/changelog.md Documents the version bump
Cargo.toml Updates dependency versions to main branch

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 1, 2025

CodSpeed Instrumentation Performance Report

Merging #335 will not alter performance

Comparing update-egglog (c2ab937) with main (85d283c)

Summary

✅ 7 untouched benchmarks

@saulshanabrook saulshanabrook merged commit 0fc9674 into main Sep 1, 2025
21 checks passed
@saulshanabrook saulshanabrook deleted the update-egglog branch September 1, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants