Skip to content

Conversation

@benkroeger
Copy link

@benkroeger benkroeger commented Apr 18, 2025

Fixes #35

Which problem is this pull request solving?

TypeScript error TS2742 when calling subclass with plugins option

List other issues or pull requests related to this problem

This fixes #35

Describe the solution you've chosen

Example: I've fixed this by exporting SpecificErrorClass from main.d.ts

Describe alternatives you've considered

none

Checklist

Please add a x inside each checkbox:

  • I have read the contribution guidelines.
  • I have added tests (we are enforcing 100% test coverage).
  • I have added documentation in the README.md, the docs directory (if
    any)
  • The status checks are successful (continuous integration). Those can be
    seen below.

@ehmicky
Copy link
Owner

ehmicky commented Apr 29, 2025

Hi @benkroeger,

Thanks a lot for this PR!

This looks good. However, could you please add the following, as suggested from this previous PR #27:

Thanks!

@ehmicky
Copy link
Owner

ehmicky commented May 21, 2025

@benkroeger Would you prefer me to do it? If so, please let me know, and I'll go ahead. 👍

@benkroeger
Copy link
Author

@ehmicky I'd prefer you to do it

@ehmicky
Copy link
Owner

ehmicky commented May 26, 2025

Done! 👍

@ehmicky ehmicky closed this May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(another) TypeScript error TS2742 when calling subclass with plugins option

2 participants