Conversation
…cated APIs - Upgrade egui-phosphor 0.11 -> 0.12 to resolve epaint version conflict - Split eframe::App::update into logic() (non-UI state) + ui() (rendering) - Replace SidePanel::left().show(ctx) with Panel::left().show_inside(ui) - Replace CentralPanel::show(ctx) with CentralPanel::show_inside(ui) - Rename ctx.style()/set_style() to ctx.global_style()/set_global_style() - Simplify ui.ctx().open_url/animate_bool via Ui -> Context Deref - Update threading model docs and all update() references to logic()
- Use ScrollArea::content_margin to replace inner Frame padding wrapper - Add Label::truncate + show_tooltip_when_elided for process names - Font hinting (skrifa) and ScrollArea edge fading are automatic
- Fix status box header typo: '-System Status' -> '- System Status' - Replace 11 hardcoded section header strings with strings::cli constants - Add section_divider() and box_header_line() helpers for consistent formatting - Add tests for new helpers (width, centering, long title saturation) - Eliminates 12 previously-dead string constants in strings::cli that were defined but never referenced (survived dead_code lint via lib.rs pub API)
When the user toggled autostart, both draw_integration() in settings.rs and sync_integration_settings() in app.rs called set_autostart() on the same frame - a redundant registry write. - Remove autostart logic from sync_integration_settings() (settings.rs already handles it with error feedback and rollback) - Add autostart sync after settings import in draw_backup() so imported auto_start preferences are still applied to the registry - Startup sync in MagicXApp::new() remains (ensures exe path is current)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces several improvements and updates across the codebase, focusing on modernizing dependencies, enhancing the display output formatting, and refactoring the GUI code to align with recent changes in the
eframe/eguiframework. The most significant changes include updating dependencies, refactoring display section formatting for consistency, and adapting the GUI logic to the neweframeAPI.Dependency Updates:
eframe,egui_extras, andegui-phosphorto their latest versions inCargo.tomlto ensure compatibility and access to new features. [1] [2]Display Formatting Improvements:
section_dividerandbox_header_linehelper functions insrc/display.rsfor consistent section headers and box titles, replacing hardcoded strings throughout the status and summary outputs.GUI Refactoring for eframe 0.34:
logicanduimethods instead of the deprecatedupdatemethod, and refactored related functions and documentation accordingly. [1] [2] [3] [4] [5] [6] [7] [8]set_global_styleandglobal_stylein line with the latesteguiAPI.Integration and Settings Handling:
Miscellaneous:
.github/hooks/context-mode.jsonfile to define pre- and post-tool use hooks for VSCode Copilot integration.These changes collectively modernize the codebase, improve output clarity, and ensure compatibility with the latest dependencies.
Type of Change
Related Issues
N/A
Checklist
cargo fmt— code is formattedcargo clippy— no lint errors (deny level)cargo test— all tests passcargo build --release— release build succeedscargo doc— documentation builds without warningsTesting
Stability checks passed: formatting, clippy, tests, and benchmarks.Provided a simplified, release-note-ready changelog in short bullet points as requested.
Screenshots / Output
N/A
Changelogs