Skip to content

Support url path in HttpTransport #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eht16 merged 2 commits into from
Jan 26, 2025
Merged

Support url path in HttpTransport #103

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a8d69c
Add path to HttpTransport
memlucky71 Dec 29, 2024
3d2fbe2
Add path to HttpTransport - core review
memlucky71 Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions logstash_async/transport.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ class Transport(ABC):
:type host: str
:param port: The TCP/UDP port.
:type port: int
:param path: The path for the transport.
:type path: str
:param timeout: The connection timeout.
:type timeout: None or float
:param ssl_enable: Activates TLS.
Expand All @@ -57,13 +59,15 @@ def __init__(
self,
host: str,
port: int,
path: str,
timeout: Union[None, float],
ssl_enable: bool,
ssl_verify: Union[bool, str],
use_logging: bool,
):
self._host = host
self._port = port
self._path = path
self._timeout = None if timeout is TimeoutNotSet else timeout
self._ssl_enable = ssl_enable
self._ssl_verify = ssl_verify
Expand Down Expand Up @@ -277,6 +281,8 @@ class HttpTransport(Transport):
:type host: str
:param port: The TCP port of the logstash HTTP server.
:type port: int
:param path: The path of the logstash HTTP server.
:type path: str
:param timeout: The connection timeout. (Default: None)
:type timeout: float
:param ssl_enable: Activates TLS. (Default: True)
Expand All @@ -301,13 +307,14 @@ def __init__(
self,
host: str,
port: int,
path: str = '',
timeout: Union[None, float] = TimeoutNotSet,
ssl_enable: bool = True,
ssl_verify: Union[bool, str] = True,
use_logging: bool = False,
**kwargs
):
super().__init__(host, port, timeout, ssl_enable, ssl_verify, use_logging)
super().__init__(host, port, path, timeout, ssl_enable, ssl_verify, use_logging)
self._username = kwargs.get('username', None)
self._password = kwargs.get('password', None)
self._max_content_length = kwargs.get('max_content_length', 100 * 1024 * 1024)
Expand All @@ -324,7 +331,7 @@ def url(self) -> str:
protocol = 'http'
if self._ssl_enable:
protocol = 'https'
return f'{protocol}://{self._host}:{self._port}'
return f'{protocol}://{self._host}:{self._port}/{self._path}'

def __batches(self, events: list) -> Iterator[list]:
"""Generate dynamic sized batches based on the max content length.
Expand Down
Loading