Add Track-Protocluster Association - #130
Merged
Merged
Conversation
Merged
7 tasks
veprbl
reviewed
Nov 2, 2025
veprbl
previously approved these changes
Nov 4, 2025
Member
|
I don't think we need the review discussion, it the type is what we already approved, the link distinction is a technicality at this point. |
veprbl
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This PR introduces the
edm4eic::TrackProtoClusterMatch, which parallelsedm4eic::TrackProtoClusterLinkbut is an association and thus works with JANA2 2.4.2. This type is intended to provide a stopgap as described in EDM4eic#129.What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.