Merged
Conversation
The types in edm4eic are not known to edm4hep2json, so all this test does is ensure that it can be called and then print a bunch of warnings
The input file that is passed does not have the data that would make this test pass in any scenario
isValid has been deprecated for the more appropriately named hasID in AIDASoft/podio#860
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
GENERATE_DOCS)CTestto make sure thatBUILD_TESTINGisONby defaultWhat kind of change does this PR introduce?
BUILD_TESTINGhas beenOFFby default so far, quite a few of the tests needed fixes to compileBUILD_TESTING=ONby default and newGENERATE_DOCScmake optionPlease check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
Does this PR change default behavior?
Yes,
BUILD_TESTINGisONby default now.Technically this might be three (or four) PRs instead of only one. I am happy to split them into more topical PRs if desired. I have also rather generously removed tests that were not applicable for EDM4eic or that could never work in the current setup. I can also bring a few of them back with appropriate content if desired / necessary.