Add CALOROC1B data model #134
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
mhkim-anl
requested review from
mariakzurek,
ruse-traveler,
sly2j,
veprbl and
wdconinc
Contributor
|
Hi all, I wanted to record action items from the 11.25.2025 BIC Simulation Meeting. Let me know if anything's missing/incorrect/misrepresentative!
Then I can't remember if we explicitly talked about this in the meeting, but it might make sense to rename |
Member
|
HGCROC is not the same as CALOROC1A? |
Member
|
If yes, then what is the better name? |
Contributor
Ah! Then I may have misunderstood the discussion... What's the difference between the 1A and the HGC? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This PR introduces a data model for the CALOROC1B chip. Although it is not yet available in hardware, it is, together with the HGCROC chip, a strong candidate for the calorimeter readout in the ePIC experiment. Having a dedicated CALOROC1B data model allows us to study its expected performance in detail. The performance not only can be directly compared with the HGCROC-based performance, but also provide useful input for the CALOROC1B chip development.
Since the main difference between the CALOROC1B and HGCROC (CALOROC1A) chip is whether the chip has TOT or low gain ADC, the data model has been implemented based on
edm4eic::HGCROCSampleandedm4eic::RawHGCROCHit.What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No
Does this PR change default behavior?
No