Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #13 by migrating the documentation build process from running in an Alpine Linux container to running inside eic-shell. This ensures that edm4hep and podio headers are properly resolved during Doxygen documentation generation.
Changes:
- Removed Alpine Linux container configuration from the build-docs job
- Migrated Doxygen execution to run inside eic-shell using cvmfs-contrib/github-action-cvmfs and eic/run-cvmfs-osg-eic-shell actions
- Removed explicit installation steps for doxygen, graphviz, tar, and bash (now provided by eic-shell)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This PR aims to fix #13 by running the doxygen job inside eic-shell. This ensures that the edm4hep (and podio) headers are resolved.