Merging of irt 2 related changes to EDM4eic#155
Draft
chchatte92 wants to merge 3 commits intomainfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This PR introduces the changes related to the irt v2. Regarding the global PID, the data structure introduces a dummy variable. The actual and final model is subjected to discussion and approval.
What kind of change does this PR introduce?
The PR introduces changes related to IRT2 into EDM4eic.
Please check if this PR fulfils the following:
Partially! The functionality works locally. PODIO-style associations are still to be checked.
Does this PR introduce breaking changes? What changes might users need to make to their code?
Introduces IrtEvent in the data structure that has to be discussed.
Does this PR change default behavior?
Partially for IRT users.