Skip to content

Fix photon cluster matching by adding charge check in MatchClusters algorithm #2138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix photon cluster matching by adding charge check in MatchClusters algorithm #2138

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5984065
Initial plan
Copilot Oct 17, 2025
06e374c
Add charge check before matching clusters to tracks
Copilot Oct 17, 2025
09270ca
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions src/algorithms/reco/MatchClusters.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,19 @@ void MatchClusters::process(const MatchClusters::Input& input,
}

if (clusterMap.contains(mcID)) {
const auto& clus = clusterMap[mcID];
debug(" --> found matching cluster with energy: {}", clus.getEnergy());
debug(" --> adding cluster to reconstructed particle");
outpart.addToClusters(clus);
clusterMap.erase(mcID);
const auto& mc_particle = (*mcparticles)[mcID];

// Only match cluster if the MC particle is actually charged
if (mc_particle.getCharge() != 0.0F) {
const auto& clus = clusterMap[mcID];
debug(" --> found matching cluster with energy: {}", clus.getEnergy());
debug(" --> adding cluster to reconstructed particle");
outpart.addToClusters(clus);
clusterMap.erase(mcID);
} else {
debug(" --> mcID {} corresponds to neutral particle (PDG: {}), skipping cluster match",
mcID, mc_particle.getPDG());
}
}

// create truth associations
Expand Down
Loading