Skip to content

feat: re-enable emulated arm64 builds on eicweb #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 44 commits into
base: master
Choose a base branch
from
Open

feat: re-enable emulated arm64 builds on eicweb #50

wants to merge 44 commits into from

Conversation

@wdconinc
Copy link
Contributor

@wdconinc wdconinc commented Nov 19, 2025

Briefly, what does this PR introduce?

This PR re-enables the arm64 builds on eicweb, now that we have native builds on github.

What kind of change does this PR introduce?

  • Bug fix (issue: arm64 builds do not get published since eicweb does the publishing)
  • New feature (issue #__)
  • Documentation update
  • Other: __

@wdconinc
feat: re-enable arm64 builds, per ROOT team request
253bd4a
@wdconinc
fix: add linux/arm64/v8 to dependent jobs needs
80d71e6
@wdconinc
feat: parallelize amd64 and arm64; merge in manifest
8006535
@wdconinc
fix: jobs:base:multi:needs as array
5e70e67
@wdconinc
fix: docker buildx build --tag
4879d1e
@wdconinc
feat: store build metadata json
7e0f213
@wdconinc
fix: avoid declare and append to var instead
f0a70d1
@wdconinc
fix: mkdir metadata dir
95af267
@wdconinc
fix: fun with anchors
7a51823
@wdconinc
fix: apk add jq
cfe8254
@wdconinc
test: disable arm again for now
95313d6
@wdconinc
test: disable arm again for now (eic)
5c2305b
@wdconinc
fix: allow building eic container from base by digest
8821e1d
@wdconinc
fix: use lowercase for local vars
2484a15
@wdconinc
fix: multi -> multiarch; in separate stage
2900844
@wdconinc
fix: add multiarch stages
b1f3f7b
@wdconinc
fix: push internal tag
ec01fa1
@wdconinc
feat: split amd64 and arm64 matrices
7ead42d
@wdconinc
fix: use amd64 anchor in multiarch
9c846fa
@wdconinc
fix: eic: mkdir metadata dir
29202bc
@wdconinc
fix: build exports BUILD_DIGEST; get artifacts in benchmarks trigger
769deba
@wdconinc
fix: use BUILD_DIGEST in triggered benchmarks
8a572fe
@wdconinc
fix: eic-arm64: allow_failure: true
49bd977
@wdconinc
fix: base: apk add jq
df9756d
@wdconinc
fix: remove matrix from multiarch jobs
3e2e575
@wdconinc
fix: always run multiarch; skip arm64 on trigger
c30aac3
@wdconinc
fix: avoid metadata/metadata
6b7c936
@wdconinc
fix: avoid metadata/metadata in eic:multiarch
612d42f
@wdconinc
fix: *:multiarch: arm64: optional: true
3caeb97
@wdconinc
fix: *:multiarch: needs: use job hash instead of array
2cf7e4b
@wdconinc
fix: eic:multiarch: apk add jq [ci skip]
2910322
@wdconinc
fix: docker image history and manifest inspect [ci skip]
ea4b5f7
@wdconinc
fix: use BUILDER_SIGIL in Dockerfile too [ci skip]
c22c031
@wdconinc
fix: define BINFMT_IMAGE for multiarch [ci skip]
5506bbc
@wdconinc
test: use tonistiigi/binfmt:qemu-v9.2.2 for multiarch
59a27b7
@wdconinc
fix: run BINFMT_IMAGE --version
c0f8fd2
@wdconinc
fix: ensure BUILD_DIGEST is defined
cc2c5f2
@wdconinc
fix: disable docker image history for now
ff4bfee
@wdconinc
fix: *:multiarch: needs: job: version
c2dfb23
@wdconinc
fix: docker buildx imagetools create for tagging manifests
d94d8a0
@wdconinc
test: comment out docker buildx imagetools inspect
e360700
@wdconinc
fix: re-enable docker buildx imagetools inspect with semicolon
90fbbc3
@wdconinc
Modify multi-arch manifest merging to use docker buildx imagetools
36468a8
@wdconinc
Fix name of upstream job for user_spack_environment
fbecf75
Copilot AI review requested due to automatic review settings November 19, 2025 16:05
@wdconinc
Copy link
Contributor Author

wdconinc commented Nov 19, 2025

Note https://eicweb.phy.anl.gov/containers/eic_container/-/merge_requests/1233#note_30645.

Copilot AI reviewed Nov 19, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot finished reviewing on behalf of wdconinc November 19, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wdconinc