Revert B0 dimension changes to restore reconstruction to 25.07.0 performance #988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ormance This partially reverts d1be407
github-actions
bot
added
the
topic: far-forward
Member
Author
|
I guess, this will not work for simulation. |
Contributor
|
This will create overlaps with the new cryostat geometry. |
Member
Author
|
The overlaps appear to be small 0.05 (should be the default unit for TGeo is mm), it may be possible to wiggle something in. |
Member
Author
|
I ran it locally and it looks like the sizes in 43ff6cf are not sufficient to recover the original performance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially reverts d1be407
Briefly, what does this PR introduce?
This is a workaround for #987
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No
Does this PR change default behavior?
Yes