Modeling source change verdicts#417
Open
m-linner-ericsson wants to merge 3 commits intoeiffel-community:masterfrom
Open
Modeling source change verdicts#417m-linner-ericsson wants to merge 3 commits intoeiffel-community:masterfrom
m-linner-ericsson wants to merge 3 commits intoeiffel-community:masterfrom
Conversation
e-backmark-ericsson
requested changes
Dec 22, 2025
Member
e-backmark-ericsson
left a comment
There was a problem hiding this comment.
None of my comments are really critical, but I'd prefer that you at least consider them before merging.
|
|
||
| 1. A developer pushes code for review (`SCC 1`). | ||
| 1. The first reviewer gives a `+1` as they think it looks good which generates a `codeReviewed`:`SUCCESS` (`CLM 1`). | ||
| 1. The second reviewer spots a serious mistake and gives a `-2` which generates a `readyToMerge`:`FAILURE` (`CLM 2`). |
Member
There was a problem hiding this comment.
Suggested change
| 1. The second reviewer spots a serious mistake and gives a `-2` which generates a `readyToMerge`:`FAILURE` (`CLM 2`). | |
| 1. The second reviewer spots a serious mistake and gives a `-2` which generates a `codeReviewed`:`FAILURE` (`CLM 2`). | |
e-backmark-ericsson
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applicable Issues
Fixes #236
Description of the Change
Alternate Designs
One could have skipped the PREDECESSOR but it was deemed good to have it.
Possible Drawbacks
None that I can think of
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Mattias Linnér mattias.linner@ericsson.com