Add basic metrics to the ETOS API#134
Open
t-persson wants to merge 5 commits intoeiffel-community:mainfrom
Open
Add basic metrics to the ETOS API#134t-persson wants to merge 5 commits intoeiffel-community:mainfrom
t-persson wants to merge 5 commits intoeiffel-community:mainfrom
Conversation
t-persson
requested review from
andmat900 and
fredjn
and removed request for
a team
t-persson
commented
Jan 29, 2026
t-persson
commented
Jan 29, 2026
andmat900
reviewed
Feb 5, 2026
andmat900
reviewed
Mar 30, 2026
| # pylint:disable=too-many-locals,too-many-statements | ||
|
|
||
|
|
||
| @REQUEST_TIME.labels(**START_LABELS).time() |
Contributor
There was a problem hiding this comment.
This will likely include decorator overhead too? Intended?
Collaborator
Author
There was a problem hiding this comment.
Since it is supposed to count request time it should be included. Not that the time we spend in decorators is enough to even notice.
andmat900
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applicable Issues
Actually found no issue for this.
Description of the Change
Added two metrics for the v1alpha and v0 routers. A histogram for request timing and a counter for total number of requests.
With these metrics we should be able to see if the ETOS API is being overloaded by requests.
Alternate Designs
I could add a lot more metrics, but this PR is mostly just to get started testing having metrics together with opentelemetry and we should investigate which metrics we need at a later stage.
Possible Drawbacks
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Tobias Persson tobias.persson@axis.com