Fix KeyError on optional execute field in recipes_from_tests#141
Merged
andmat900 merged 1 commit intoeiffel-community:mainfrom Mar 10, 2026
Merged
Conversation
Change-Id: I95ba21531c6d3c9d6b479318a38b63538b2accf3 Signed-off-by: Andrei Matveyeu <andreimu@axis.com>
t-persson
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applicable Issues
Fixes eiffel-community/etos#561
Description of the Change
The
executefield in the Environment CRDExecutionstruct is optional (omitempty), so Kubernetes omits it when the array is empty.recipes_from_tests()used a direct dictionary lookup (test["execution"]["execute"]) which raises aKeyErrorwhen the field is absent. This change uses.get("execute", [])instead, returning an empty list as the default.Alternate Designs
Could have made all execution field lookups defensive with
.get(), but onlyexecuteis actually optional in the CRD schema, so a targeted fix is more appropriate.Possible Drawbacks
None expected — this only affects the
executefield which is explicitly optional.Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Andrei Matveyeu, andreimu@axis.com