Skip to content

Respect quotation marks#63

Closed
t-persson wants to merge 6 commits intoeiffel-community:mainfrom
t-persson:respect-quotation-marks
Closed

Respect quotation marks#63
t-persson wants to merge 6 commits intoeiffel-community:mainfrom
t-persson:respect-quotation-marks

Conversation

@t-persson
Copy link
Collaborator

Applicable Issues

None found

Description of the Change

Fix a problem where if you wanted to pass in text in quotations those were stripped away by the executor.sh script.
This fix changes the ARGS to be an array instead of a string which will make sure that the quotes are kept.

I also managed to fix the tests on the side so that they do not complain (without failing) every time they ran.

Alternate Designs

None

Possible Drawbacks

The biggest drawback is that this is a massive change that could potentially break a lot of things if the previous behavior was an expected one.
We must test a bunch before marking this change for release.

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Tobias Persson tobias.persson@axis.com

@t-persson t-persson requested a review from a team as a code owner October 15, 2025 12:51
@t-persson t-persson requested review from andmat900 and fredjn and removed request for a team October 15, 2025 12:51
fredjn
fredjn previously approved these changes Oct 15, 2025
@t-persson
Copy link
Collaborator Author

This change does not work

@t-persson t-persson closed this Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants