feat(gui): switch to showing the maker fee instead of markup#279
Closed
Einliterflasche wants to merge 1 commit intomasterfrom
Closed
feat(gui): switch to showing the maker fee instead of markup#279Einliterflasche wants to merge 1 commit intomasterfrom
Einliterflasche wants to merge 1 commit intomasterfrom
Conversation
The fee is what the maker charges in excess of market exchange rate, as a percentage of the makers price. For example, if the market rate is 0.5BTC/XMR and the maker charges 0.75BTC/XMR, the fee is 33.3% since 1/3 of the maker's price goes beyond the market exchange rate.
|
I don't like the "fee" terminology. A fee for me is a fixed absolute amount. Or something charged by the system itself and not by another user. I prefer markup or another term. |
Author
|
That is true. However, I feel that having percentages going beyond 100% is more unintuitive. Perhaps, we should consider using "efficency" or something like that, which would be the percentage of the maker price that, at current rates, actually gets converted to monero. this would result in a simple 0 - 100% scale, where more = better. |
binarybaron
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fee is what the maker charges in excess of market exchange rate, as a percentage of the makers price.
For example, if the market rate is 0.5BTC/XMR and the maker charges 0.75BTC/XMR, the fee is 33.3% since 1/3 of the maker's price goes beyond the market exchange rate.