Skip to content

Comments

feat(asb): Cache quotes for performance#288

Merged
binarybaron merged 1 commit intomasterfrom
asb/cache-quotes
Apr 17, 2025
Merged

feat(asb): Cache quotes for performance#288
binarybaron merged 1 commit intomasterfrom
asb/cache-quotes

Conversation

@binarybaron
Copy link

@binarybaron binarybaron commented Apr 16, 2025

Quotes are now cached (Time-to-live of 2 minutes) to avoid overloading the maker with requests in times of high demand. We also upgraded the arti-client library to 0.29.

@binarybaron binarybaron marked this pull request as draft April 16, 2025 10:56
@binarybaron binarybaron marked this pull request as ready for review April 16, 2025 13:10
@binarybaron
Copy link
Author

@Einliterflasche This is ready for review

Copy link

@Einliterflasche Einliterflasche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@binarybaron binarybaron changed the title asb: Cache quotes for performance feat(asb): Cache quotes for performance Apr 16, 2025
@binarybaron
Copy link
Author

This doesn't compile on ARM. No idea why. Something related to aws-lc-rs? Could be caused by the arti-client upgrade.

@binarybaron
Copy link
Author

 --- stderr
  Consider installing the bindgen-cli: `cargo install --force --locked bindgen-cli`
  See our User Guide for more information about bindgen:https://aws.github.io/aws-lc-rs/index.html
  Failure invoking external bindgen! External bindgen command failed.
  thread 'main' panicked at /cargo/registry/src/index.crates.io-6f17d22bba15001f/aws-lc-sys-0.28.0/builder/main.rs:662:5:
  aws-lc-sys build failed. Please enable the 'bindgen' feature on aws-lc-rs or aws-lc-sys.For more information, see the aws-lc-rs User Guide: https://aws.github.io/aws-lc-rs/index.html
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@binarybaron binarybaron merged commit b355942 into master Apr 17, 2025
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants