Skip to content

Conversation

@nabijaczleweli
Copy link

Closes #798

@binarybaron
Copy link

@silverf1sh I know you also wanted to work on this. @nabijaczleweli beat you to it but I still want to encourage contributions from others. I'll award you 0.1 XMR for a review of this PR.

Just comment on things you find confusing or that you think could be implemented in a cleaner fashion. @nabijaczleweli most likely has a better understanding of the codebase than you but your comment might still prove helpful! More eyes are always better.

@binarybaron
Copy link

@silverf1sh I'd like to merge this today or tommorow though so if you are intersted in reviewing this you must do it until then. Alternatively you can open a follow up PR to correct minor things.

@coldmartian
Copy link

Appreciate It. I'll review It today.

@binarybaron
Copy link

The docker tests are not compiling.

@nabijaczleweli
Copy link
Author

All applied

Copy link

@binarybaron binarybaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge once CI runs through

@binarybaron binarybaron merged commit c59e4cd into eigenwallet:master Dec 8, 2025
13 of 55 checks passed
@binarybaron
Copy link

0.5 XMR paid out to @nabijaczleweli. 0.1 XMR paid out to @silverf1sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[0.5 XMR] Extract monero/wallet.rs into its own crate

3 participants