-
Notifications
You must be signed in to change notification settings - Fork 40
refactor: extract swap/src/monero/wallet.rs to new monero-wallet crate #803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@silverf1sh I know you also wanted to work on this. @nabijaczleweli beat you to it but I still want to encourage contributions from others. I'll award you 0.1 XMR for a review of this PR. Just comment on things you find confusing or that you think could be implemented in a cleaner fashion. @nabijaczleweli most likely has a better understanding of the codebase than you but your comment might still prove helpful! More eyes are always better. |
|
@silverf1sh I'd like to merge this today or tommorow though so if you are intersted in reviewing this you must do it until then. Alternatively you can open a follow up PR to correct minor things. |
|
Appreciate It. I'll review It today. |
|
The docker tests are not compiling. |
303a7df to
8ca24c7
Compare
|
All applied |
8ca24c7 to
4756a3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will merge once CI runs through
|
0.5 XMR paid out to @nabijaczleweli. 0.1 XMR paid out to @silverf1sh |
Closes #798