Skip to content

Conversation

@binarybaron
Copy link

@binarybaron binarybaron commented Dec 8, 2025

Note

Add optional Monero ReserveProofV2 (with address and message) to bid quotes and wire proof generation/serialization through ASB, serde, and CLI.

  • Protocol/Quote:
    • Extend BidQuote with optional reserve_proof: Option<ReserveProofWithAddress> (address, proof, message); update ZERO and remove Copy semantics where needed.
    • Add ReserveProofWithAddress type; serialize address via swap_serde::monero::address_serde.
  • ASB/Event Loop:
    • Generate reserve proof from Monero wallet (message = local peer ID) and include in quotes via updated make_quote.
    • Adjust quote response to clone (since BidQuote no longer Copy).
  • Serde:
    • Introduce swap_serde::monero::address_serde for monero::Address (string serialize/deserialize).
  • Quote logic:
    • Update make_quote signature to accept get_reserve_proof and embed proof; on failure, log and omit proof.
  • CLI/Tests:
    • Handle reserve_proof in dummy quotes; minor borrow fix when filtering quotes; update tests to pass a no-proof closure.

Written by Cursor Bugbot for commit 7cebaf8. This will update automatically on new commits. Configure here.

@binarybaron
Copy link
Author

bugbot run

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no bugs!


@binarybaron binarybaron marked this pull request as ready for review December 8, 2025 14:44
@binarybaron binarybaron merged commit 8208798 into master Dec 8, 2025
18 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants