feat: Full import map support #126
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: This ads full import map support and can in some cases, depending on the import map, make a build differ from previous builds. Though; the build should from now on be more correct than previous builds due to improvements in the mapping algorithm.
torbs
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: This ads full import map support and can in some cases, depending on the import map, make a build differ from previous builds. Though; the build should from now on be more correct than previous builds due to improvements in the mapping algorithm.
The main support is done in trygve-lie/rollup-plugin-import-map#44 by using a module from the Open Web Components project for parsing and resolving import maps. Our own implementation was fairly naive and had a couple of errors in it and was missing support for scopes. This solves all this.
One thing to keep in mind is that import maps should always be resolved against a base URL. In this plugin we pick this from the Eik config since we always want to resolve against the server which will serve the final bundle. It is possible to override this with a config argument.