Skip to content

Ensure html attributes are escaped in templates #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ensure html attributes are escaped in templates #285

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions templates/CRM/Core/Page/PaymentPage.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
>
{* this is a hack in core & it's a hack here... *}
{if $core_field_name == 'cvv2'}
<span class="cvv2-icon" title="{ts}Usually the last 3-4 digits in the signature area on the back of the card.{/ts}"> </span>
<span class="cvv2-icon" title="{ts escape='htmlattribute'}Usually the last 3-4 digits in the signature area on the back of the card.{/ts}"> </span>
{/if}
{if $core_field_name == 'credit_card_type'}
<div class="crm-credit_card_type-icons"></div>
Expand Down Expand Up @@ -68,7 +68,7 @@
{/foreach}
{if empty($display_fields)}<p>{ts}Please Click the pay now button if you are not automatically redirected{/ts}</p>{/if}

<input class='form-submit default crm-form-submit' type="submit" value="{ts}Pay now{/ts}">
<input class='form-submit default crm-form-submit' type="submit" value="{ts escape='htmlattribute'}Pay now{/ts}">
{* jQuery validate *}
{include file="CRM/Form/validate.tpl"}
</form>
Expand Down