feat: add option for generate command to only generate allowed message ids
#248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jassob
requested changes
May 16, 2024
Member
Jassob
left a comment
Jassob
left a comment
There was a problem hiding this comment.
Looks really good, could you please add some tests and rebase on current master?
aschiffmann
force-pushed
the
message_id_whitelist
branch
from
8a94a07 to
4a01aaf
Compare
Jassob
reviewed
May 20, 2024
Member
|
Please also rebase/fixup commits so that each commit forms one logical and coherent change, incorporate any fix/revert commits to the original commits. Also we use Conventional Commits for our commit messages, please update your commits to conform :) |
aschiffmann
force-pushed
the
message_id_whitelist
branch
from
9420312 to
912a0de
Compare
aschiffmann
changed the title
aschiffmann
changed the title
generate command to only generate allowed message ids
aschiffmann
changed the title
generate command to only generate allowed message idsgenerate command to only generate allowed message ids
aschiffmann
force-pushed
the
message_id_whitelist
branch
from
912a0de to
95a09c7
Compare
Author
aschiffmann
force-pushed
the
message_id_whitelist
branch
from
95a09c7 to
d9ece70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an message ID list option to only compile particular messages:
generate <input-dir> <output-dir> [<allowed-message-ids>...]Example:
generate dbcIn dbcOut 587 256