feat: expose compiler as part of dbc package #281
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves the DBC compiler to the `pkg/dbc` package to make it part of the public API. Currently, if you want to do anything useful with a DBC file you more or less need to re-implement parts of the compiler yourself, which gets tedious to keep up to date.
maxekman
approved these changes
Jun 12, 2024
maxekman
reviewed
Jun 12, 2024
maxekman
left a comment
maxekman
left a comment
There was a problem hiding this comment.
Still todo is to add documentation to public data structures and functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves the DBC compiler to the
pkg/dbcpackage to make it part of the public API.Currently, if you want to do anything useful with a DBC file you more or less need to re-implement parts of the compiler yourself, which gets tedious to keep up to date.