generate: deduplicate conflicting ValueDescription constants #353
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thank you for the great tool.
Summary
Fix code generation crash when multiple value descriptions share the same label but map to different raw values.
Background
Some DBC files define distinct raw values using the same textual description:
The generated Go constants would then collide:
Fix
In SignalCustomType constant generation:
This preserves stable names where possible and only adjusts those that previously failed to compile.
Resulting behavior
Examples
Input DBC:
Before (error):
After (compiles):
Pathological example (three “ok” entries: 0, 3, 5):
Notes