feat(sggit): add optional pathspecs to VerifyNoDiff#783
Draft
feat(sggit): add optional pathspecs to VerifyNoDiff#783
Conversation
Allow scoping the diff check to specific files by passing git pathspecs (e.g. "*.md", ":(exclude)vendor"). Pathspecs are passed after a "--" separator. When no pathspecs are given the entire working tree is checked, preserving backwards compatibility. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pathspecs ...stringparameter toVerifyNoDiff, allowing callers to scope the diff check to specific files (e.g."*.md",":(exclude)vendor")--separator to avoid being interpreted as flags:(exclude)pathspecsMotivation
Repos that use
VerifyNoDiffafterFormatMarkdowncurrently fail when unrelated files (e.g. regenerated Makefiles) have diffs. Scoping to"*.md"lets the check focus on whatFormatMarkdownactually touches.Test plan
go test ./tools/sggit/...— all 4 new tests passgo vet ./tools/sggit/...— clean🤖 Generated with Claude Code