Use StringComparer.Ordinal in source generator emission sorts#424
Merged
eiriktsarpalis merged 1 commit intomainfrom Apr 21, 2026
Merged
Use StringComparer.Ordinal in source generator emission sorts#424eiriktsarpalis merged 1 commit intomainfrom
eiriktsarpalis merged 1 commit intomainfrom
Conversation
The OrderBy calls added in #413 use the default string comparer, which is culture-dependent (StringComparer.CurrentCulture). This could produce different sort orders on machines with different locale settings, breaking deterministic output. Switch to StringComparer.Ordinal for all string-based sorts in the SourceFormatter. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The \OrderBy\ calls added in #413 use the default string comparer, which is culture-dependent (\StringComparer.CurrentCulture). This could produce different sort orders on machines with different locale settings, breaking deterministic output.
This PR switches all string-based \OrderBy\ calls in the \SourceFormatter\ to use \StringComparer.Ordinal.