idem minor version number cleanup#3
Open
TheBigBear wants to merge 4 commits intoeitrtechnologies:mainfrom
Open
idem minor version number cleanup#3TheBigBear wants to merge 4 commits intoeitrtechnologies:mainfrom
TheBigBear wants to merge 4 commits intoeitrtechnologies:mainfrom
Conversation
those version numbers look like salt version numbers and not idem ones. The last bit about the output of 'idem exec test.version' is invented. It blows up on my site so I do not know what this would actually report? I assume it might be the output in invented, but maybe that is well off.
Author
|
@nicholasmhughes ok, I am pretty sure the last bit telling user to do So I suggest to simply close with one or more of the following tests in closing: |
Member
|
Sounds good! Let's go with option 2. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
those version numbers look like salt version numbers and not idem ones. The last bit about the output of 'idem exec test.version' is invented. It blows up on my site so I do not know what this would actually report? I assume it might be the output in invented, but maybe that is well off.