Merge Analytical FIFO sizing PR from upstream#161
Conversation
…ifo derivation transformations. Swapping fifo sizing step to before stitch currently breaks stitching
…ndant cfg flag for jit synthesis
…nto merge/fifo_heuristic
|
📋 Docstring Check Report Checked files:
❌ Docstring check failed! Missing Docstrings Details:
📄 src/finn/analysis/fpgadataflow/dataflow_performance.py:
📄 src/finn/custom_op/fpgadataflow/addstreams.py:
📄 src/finn/custom_op/fpgadataflow/channelwise_op.py:
📄 src/finn/custom_op/fpgadataflow/convolutioninputgenerator.py:
📄 src/finn/custom_op/fpgadataflow/duplicatestreams.py:
📄 src/finn/custom_op/fpgadataflow/fmpadding.py:
📄 src/finn/custom_op/fpgadataflow/hwcustomop.py:
📄 src/finn/custom_op/fpgadataflow/labelselect.py:
📄 src/finn/custom_op/fpgadataflow/matrixvectoractivation.py:
📄 src/finn/custom_op/fpgadataflow/pool.py:
📄 src/finn/custom_op/fpgadataflow/streamingdatawidthconverter.py:
📄 src/finn/custom_op/fpgadataflow/thresholding.py:
📄 src/finn/custom_op/fpgadataflow/vectorvectoractivation.py:
📄 src/finn/transformation/fpgadataflow/derive_characteristic.py:
📄 src/finn/util/basic.py:
Total missing docstrings: 184 How to Fix:Please add docstrings to the missing functions, classes, and modules listed above. Docstring Guidelines:
Raw output from docstring checker |
|
📋 Docstring Check Report Checked files:
❌ Docstring check failed! Missing Docstrings Details:
📄 src/finn/analysis/fpgadataflow/dataflow_performance.py:
📄 src/finn/custom_op/fpgadataflow/addstreams.py:
📄 src/finn/custom_op/fpgadataflow/channelwise_op.py:
📄 src/finn/custom_op/fpgadataflow/convolutioninputgenerator.py:
📄 src/finn/custom_op/fpgadataflow/duplicatestreams.py:
📄 src/finn/custom_op/fpgadataflow/fmpadding.py:
📄 src/finn/custom_op/fpgadataflow/hwcustomop.py:
📄 src/finn/custom_op/fpgadataflow/labelselect.py:
📄 src/finn/custom_op/fpgadataflow/matrixvectoractivation.py:
📄 src/finn/custom_op/fpgadataflow/pool.py:
📄 src/finn/custom_op/fpgadataflow/streamingdatawidthconverter.py:
📄 src/finn/custom_op/fpgadataflow/thresholding.py:
📄 src/finn/custom_op/fpgadataflow/vectorvectoractivation.py:
📄 src/finn/transformation/fpgadataflow/derive_characteristic.py:
📄 src/finn/util/basic.py:
Total missing docstrings: 184 How to Fix:Please add docstrings to the missing functions, classes, and modules listed above. Docstring Guidelines:
Raw output from docstring checker |
|
📋 Docstring Check Report Checked files:
❌ Docstring check failed! Missing Docstrings Details:
📄 src/finn/analysis/fpgadataflow/dataflow_performance.py:
📄 src/finn/custom_op/fpgadataflow/addstreams.py:
📄 src/finn/custom_op/fpgadataflow/channelwise_op.py:
📄 src/finn/custom_op/fpgadataflow/convolutioninputgenerator.py:
📄 src/finn/custom_op/fpgadataflow/duplicatestreams.py:
📄 src/finn/custom_op/fpgadataflow/fmpadding.py:
📄 src/finn/custom_op/fpgadataflow/hwcustomop.py:
📄 src/finn/custom_op/fpgadataflow/labelselect.py:
📄 src/finn/custom_op/fpgadataflow/matrixvectoractivation.py:
📄 src/finn/custom_op/fpgadataflow/pool.py:
📄 src/finn/custom_op/fpgadataflow/streamingdatawidthconverter.py:
📄 src/finn/custom_op/fpgadataflow/thresholding.py:
📄 src/finn/custom_op/fpgadataflow/vectorvectoractivation.py:
📄 src/finn/transformation/fpgadataflow/derive_characteristic.py:
📄 src/finn/util/basic.py:
Total missing docstrings: 184 How to Fix:Please add docstrings to the missing functions, classes, and modules listed above. Docstring Guidelines:
Raw output from docstring checker |
|
📋 Docstring Check Report Checked files:
❌ Docstring check failed! Missing Docstrings Details:
📄 src/finn/analysis/fpgadataflow/dataflow_performance.py:
📄 src/finn/custom_op/fpgadataflow/addstreams.py:
📄 src/finn/custom_op/fpgadataflow/channelwise_op.py:
📄 src/finn/custom_op/fpgadataflow/convolutioninputgenerator.py:
📄 src/finn/custom_op/fpgadataflow/duplicatestreams.py:
📄 src/finn/custom_op/fpgadataflow/fmpadding.py:
📄 src/finn/custom_op/fpgadataflow/hwcustomop.py:
📄 src/finn/custom_op/fpgadataflow/labelselect.py:
📄 src/finn/custom_op/fpgadataflow/matrixvectoractivation.py:
📄 src/finn/custom_op/fpgadataflow/pool.py:
📄 src/finn/custom_op/fpgadataflow/streamingdatawidthconverter.py:
📄 src/finn/custom_op/fpgadataflow/thresholding.py:
📄 src/finn/custom_op/fpgadataflow/vectorvectoractivation.py:
📄 src/finn/transformation/fpgadataflow/derive_characteristic.py:
📄 src/finn/util/basic.py:
Total missing docstrings: 184 How to Fix:Please add docstrings to the missing functions, classes, and modules listed above. Docstring Guidelines:
Raw output from docstring checker |
Missed a check in refactoring which dramatically inflates conservative relaxation's fifo depth numbers.
The aggressive relaxation strategy was intended to pick the minimum fifo size determined between two different relaxation passes. This got lost in the refactoring and is now reinstated.
Removed commented-out print statements for debugging.
|
📋 Docstring Check Report Checked files:
❌ Docstring check failed! Missing Docstrings Details:
📄 src/finn/analysis/fpgadataflow/dataflow_performance.py:
📄 src/finn/custom_op/fpgadataflow/addstreams.py:
📄 src/finn/custom_op/fpgadataflow/attention.py:
📄 src/finn/custom_op/fpgadataflow/channelwise_op.py:
📄 src/finn/custom_op/fpgadataflow/convolutioninputgenerator.py:
📄 src/finn/custom_op/fpgadataflow/duplicatestreams.py:
📄 src/finn/custom_op/fpgadataflow/elementwise_binary.py:
📄 src/finn/custom_op/fpgadataflow/fmpadding.py:
📄 src/finn/custom_op/fpgadataflow/hls/replicate_stream_hls.py:
📄 src/finn/custom_op/fpgadataflow/hwcustomop.py:
📄 src/finn/custom_op/fpgadataflow/labelselect.py:
📄 src/finn/custom_op/fpgadataflow/matrixvectoractivation.py:
📄 src/finn/custom_op/fpgadataflow/pool.py:
📄 src/finn/custom_op/fpgadataflow/replicate_stream.py:
📄 src/finn/custom_op/fpgadataflow/streamingdatawidthconverter.py:
📄 src/finn/custom_op/fpgadataflow/thresholding.py:
📄 src/finn/custom_op/fpgadataflow/vectorvectoractivation.py:
📄 src/finn/transformation/fpgadataflow/derive_characteristic.py:
📄 src/finn/util/basic.py:
Total missing docstrings: 327 How to Fix:Please add docstrings to the missing functions, classes, and modules listed above. Docstring Guidelines:
Raw output from docstring checker |
…nto merge/fifo_heuristic
|
📋 Docstring Check Report Checked files:
❌ Docstring check failed! Missing Docstrings Details:
📄 src/finn/analysis/fpgadataflow/dataflow_performance.py:
📄 src/finn/custom_op/fpgadataflow/addstreams.py:
📄 src/finn/custom_op/fpgadataflow/attention.py:
📄 src/finn/custom_op/fpgadataflow/channelwise_op.py:
📄 src/finn/custom_op/fpgadataflow/convolutioninputgenerator.py:
📄 src/finn/custom_op/fpgadataflow/duplicatestreams.py:
📄 src/finn/custom_op/fpgadataflow/elementwise_binary.py:
📄 src/finn/custom_op/fpgadataflow/fmpadding.py:
📄 src/finn/custom_op/fpgadataflow/hls/replicate_stream_hls.py:
📄 src/finn/custom_op/fpgadataflow/hwcustomop.py:
📄 src/finn/custom_op/fpgadataflow/labelselect.py:
📄 src/finn/custom_op/fpgadataflow/matrixvectoractivation.py:
📄 src/finn/custom_op/fpgadataflow/pool.py:
📄 src/finn/custom_op/fpgadataflow/replicate_stream.py:
📄 src/finn/custom_op/fpgadataflow/streamingdatawidthconverter.py:
📄 src/finn/custom_op/fpgadataflow/thresholding.py:
📄 src/finn/custom_op/fpgadataflow/vectorvectoractivation.py:
📄 src/finn/templates/python_driver/driver.py:
📄 src/finn/transformation/fpgadataflow/derive_characteristic.py:
📄 src/finn/util/basic.py:
Total missing docstrings: 332 How to Fix:Please add docstrings to the missing functions, classes, and modules listed above. Docstring Guidelines:
Raw output from docstring checker |
|
📋 Docstring Check Report Checked files:
❌ Docstring check failed! Missing Docstrings Details:
📄 src/finn/analysis/fpgadataflow/dataflow_performance.py:
📄 src/finn/custom_op/fpgadataflow/addstreams.py:
📄 src/finn/custom_op/fpgadataflow/attention.py:
📄 src/finn/custom_op/fpgadataflow/channelwise_op.py:
📄 src/finn/custom_op/fpgadataflow/convolutioninputgenerator.py:
📄 src/finn/custom_op/fpgadataflow/duplicatestreams.py:
📄 src/finn/custom_op/fpgadataflow/elementwise_binary.py:
📄 src/finn/custom_op/fpgadataflow/fmpadding.py:
📄 src/finn/custom_op/fpgadataflow/hls/replicate_stream_hls.py:
📄 src/finn/custom_op/fpgadataflow/hwcustomop.py:
📄 src/finn/custom_op/fpgadataflow/labelselect.py:
📄 src/finn/custom_op/fpgadataflow/matrixvectoractivation.py:
📄 src/finn/custom_op/fpgadataflow/pool.py:
📄 src/finn/custom_op/fpgadataflow/replicate_stream.py:
📄 src/finn/custom_op/fpgadataflow/streamingdatawidthconverter.py:
📄 src/finn/custom_op/fpgadataflow/thresholding.py:
📄 src/finn/custom_op/fpgadataflow/vectorvectoractivation.py:
📄 src/finn/templates/python_driver/driver.py:
📄 src/finn/transformation/fpgadataflow/derive_characteristic.py:
📄 src/finn/util/basic.py:
Total missing docstrings: 332 How to Fix:Please add docstrings to the missing functions, classes, and modules listed above. Docstring Guidelines:
Raw output from docstring checker |
|
📋 Docstring Check Report Checked files:
❌ Docstring check failed! Missing Docstrings Details:
📄 src/finn/analysis/fpgadataflow/dataflow_performance.py:
📄 src/finn/custom_op/fpgadataflow/addstreams.py:
📄 src/finn/custom_op/fpgadataflow/attention.py:
📄 src/finn/custom_op/fpgadataflow/channelwise_op.py:
📄 src/finn/custom_op/fpgadataflow/convolutioninputgenerator.py:
📄 src/finn/custom_op/fpgadataflow/duplicatestreams.py:
📄 src/finn/custom_op/fpgadataflow/elementwise_binary.py:
📄 src/finn/custom_op/fpgadataflow/fmpadding.py:
📄 src/finn/custom_op/fpgadataflow/hls/replicate_stream_hls.py:
📄 src/finn/custom_op/fpgadataflow/hwcustomop.py:
📄 src/finn/custom_op/fpgadataflow/labelselect.py:
📄 src/finn/custom_op/fpgadataflow/matrixvectoractivation.py:
📄 src/finn/custom_op/fpgadataflow/pool.py:
📄 src/finn/custom_op/fpgadataflow/replicate_stream.py:
📄 src/finn/custom_op/fpgadataflow/streamingdatawidthconverter.py:
📄 src/finn/custom_op/fpgadataflow/thresholding.py:
📄 src/finn/custom_op/fpgadataflow/vectorvectoractivation.py:
📄 src/finn/templates/python_driver/driver.py:
📄 src/finn/transformation/fpgadataflow/derive_characteristic.py:
📄 src/finn/util/basic.py:
Total missing docstrings: 332 How to Fix:Please add docstrings to the missing functions, classes, and modules listed above. Docstring Guidelines:
Raw output from docstring checker |
|
📋 Docstring Check Report ❌ Docstring check failed! Missing Docstrings Details:📄 src/finn/custom_op/fpgadataflow/addstreams.py:
📄 src/finn/custom_op/fpgadataflow/channelwise_op.py:
📄 src/finn/custom_op/fpgadataflow/convolutioninputgenerator.py:
📄 src/finn/custom_op/fpgadataflow/duplicatestreams.py:
📄 src/finn/custom_op/fpgadataflow/fmpadding.py:
📄 src/finn/custom_op/fpgadataflow/hwcustomop.py:
📄 src/finn/custom_op/fpgadataflow/labelselect.py:
📄 src/finn/custom_op/fpgadataflow/matrixvectoractivation.py:
📄 src/finn/custom_op/fpgadataflow/pool.py:
📄 src/finn/custom_op/fpgadataflow/streamingdatawidthconverter.py:
📄 src/finn/custom_op/fpgadataflow/thresholding.py:
📄 src/finn/custom_op/fpgadataflow/vectorvectoractivation.py:
📄 src/finn/templates/python_driver/driver.py:
📄 src/finn/transformation/fpgadataflow/derive_characteristic.py:
📄 src/finn/util/basic.py:
Total missing docstrings: 163 How to Fix:Please add docstrings to the missing functions, classes, and modules listed above. Docstring Guidelines:
Raw output from docstring checker |
Attempt to merge Xilinx#1185 before it is merged into the upstream dev branch.