Skip to content

feat: add HolographicMaterial tsx component#3

Open
ImEins wants to merge 2 commits intoektogamat:mainfrom
ImEins:HolographicMaterial-tsx
Open

feat: add HolographicMaterial tsx component#3
ImEins wants to merge 2 commits intoektogamat:mainfrom
ImEins:HolographicMaterial-tsx

Conversation

@ImEins
Copy link

@ImEins ImEins commented Sep 1, 2024

Hello,

First of all, thank you so much for your hard work on this project! I really appreciate the effort you've put into creating this.

I wanted to let you know that I’ve been using your component and found it really useful. To better suit my project’s needs, I made a few adjustments to convert it into a TSX component. The changes include adapting the code for TypeScript, adding type definitions, and ensuring compatibility with TypeScript projects.

Please review the changes and let me know if there are any modifications you'd like me to make. I hope this can be helpful for others who might be working with TypeScript as well.

Thanks again for your great work!

@ektogamat
Copy link
Owner

Hey buddy. Thank you so so much for your contribution :). To be honest, I have no idea how to use tsx hehe.If I accept this, would it still work on non-tsx environments? I'm only using jsx mostly. Thank you again!

@ImEins
Copy link
Author

ImEins commented Sep 2, 2024

Hey buddy. Thank you so so much for your contribution :). To be honest, I have no idea how to use tsx hehe.If I accept this, would it still work on non-tsx environments? I'm only using jsx mostly. Thank you again!

Yes, it will work, but you'll need to install TypeScript and the necessary types like @types/three. The idea behind this component is to have a TSX version ready for a TypeScript environment. If you'd like, I can also help create a TypeScript branch or repo for your entire project. Just let me know, and I’ll add it to my to-do list.

Thanks again, mate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants