You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First of all, thank you so much for your hard work on this project! I really appreciate the effort you've put into creating this.
I wanted to let you know that I’ve been using your component and found it really useful. To better suit my project’s needs, I made a few adjustments to convert it into a TSX component. The changes include adapting the code for TypeScript, adding type definitions, and ensuring compatibility with TypeScript projects.
Please review the changes and let me know if there are any modifications you'd like me to make. I hope this can be helpful for others who might be working with TypeScript as well.
Hey buddy. Thank you so so much for your contribution :). To be honest, I have no idea how to use tsx hehe.If I accept this, would it still work on non-tsx environments? I'm only using jsx mostly. Thank you again!
Hey buddy. Thank you so so much for your contribution :). To be honest, I have no idea how to use tsx hehe.If I accept this, would it still work on non-tsx environments? I'm only using jsx mostly. Thank you again!
Yes, it will work, but you'll need to install TypeScript and the necessary types like @types/three. The idea behind this component is to have a TSX version ready for a TypeScript environment. If you'd like, I can also help create a TypeScript branch or repo for your entire project. Just let me know, and I’ll add it to my to-do list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
First of all, thank you so much for your hard work on this project! I really appreciate the effort you've put into creating this.
I wanted to let you know that I’ve been using your component and found it really useful. To better suit my project’s needs, I made a few adjustments to convert it into a TSX component. The changes include adapting the code for TypeScript, adding type definitions, and ensuring compatibility with TypeScript projects.
Please review the changes and let me know if there are any modifications you'd like me to make. I hope this can be helpful for others who might be working with TypeScript as well.
Thanks again for your great work!