Conversation
Fix fmt and clippy.
Make interface functions public.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This reverts commit b2171d8.
Co-authored-by: chriseth <9073706+chriseth@users.noreply.github.com>
[WIP] Address feedback on profiling removal from original PR
Co-authored-by: chriseth <9073706+chriseth@users.noreply.github.com>
Use Itertools::sorted_by() to avoid cloning rules vector in profiling report
ekzhang
changed the title
This code is always generated even when profiling is turned off. I wasn't confident enough in the Rust compiler that it would understand that a bunch of `HashMap` function calls would have no side-effects and can be optimized away in the `run()` method so I'm removing this for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Via @chriseth
This adds:
It also makes the auto-generated
Crepestruct and functions likerun()public outside of the module, which helps with ergonomics.I didn't include the upstream implementation of profiling because this code is always generated even when profiling is turned off. I wasn't confident enough in the Rust compiler that it would understand that a bunch of
HashMapfunction calls would have no side-effects and can be optimized away in therun()method so I'm removing this for now.