Video listing optimization and caching #1389
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- indexes in migration - videos count sql optimization - video listings cache system
ferishili
added
type:enhancement
v:3
tgloeggl
requested changes
Aug 21, 2025
| @@ -5,6 +5,7 @@ | |||
| use Opencast\Models\REST\ApiPlaylistsClient; | |||
| use Opencast\Helpers\PlaylistMigration; | |||
| use Opencast\Errors\Error; | |||
| use Opencast\Caching\VideosCaching; | |||
There was a problem hiding this comment.
Suggested change
| use Opencast\Caching\VideosCaching; |
Comment on lines
+579
to
+580
| (new VideosCaching())->playlistVideos($this->id)->expire(); | ||
|
|
There was a problem hiding this comment.
Suggested change
| (new VideosCaching())->playlistVideos($this->id)->expire(); |
| @@ -10,6 +10,7 @@ | |||
| use Opencast\Models\REST\ApiWorkflowsClient; | |||
| use Opencast\Models\Helpers; | |||
| use Opencast\Models\ScheduledRecordings; | |||
| use Opencast\Caching\VideosCaching; | |||
There was a problem hiding this comment.
Suggested change
| use Opencast\Caching\VideosCaching; |
Comment on lines
+1286
to
+1307
|
|
||
| /** | ||
| * @inheritDoc | ||
| * | ||
| * Overriding store method, in order to expire caches. | ||
| */ | ||
| public function store() | ||
| { | ||
| VideosCaching::expireAllVideoCaches($this); | ||
| return parent::store(); | ||
| } | ||
|
|
||
| /** | ||
| * @inheritDoc | ||
| * | ||
| * Overriding delete method, in order to expire caches. | ||
| */ | ||
| public function delete() | ||
| { | ||
| VideosCaching::expireAllVideoCaches($this); | ||
| return parent::delete(); | ||
| } |
There was a problem hiding this comment.
Suggested change
| /** | |
| * @inheritDoc | |
| * | |
| * Overriding store method, in order to expire caches. | |
| */ | |
| public function store() | |
| { | |
| VideosCaching::expireAllVideoCaches($this); | |
| return parent::store(); | |
| } | |
| /** | |
| * @inheritDoc | |
| * | |
| * Overriding delete method, in order to expire caches. | |
| */ | |
| public function delete() | |
| { | |
| VideosCaching::expireAllVideoCaches($this); | |
| return parent::delete(); | |
| } |
| @@ -8,6 +8,7 @@ | |||
| use Opencast\OpencastController; | |||
There was a problem hiding this comment.
The changes in this file need to be reverted
| @@ -12,6 +12,7 @@ | |||
| use Opencast\Models\Playlists; | |||
There was a problem hiding this comment.
The changes in this file need to be reverted
| @@ -8,31 +8,49 @@ | |||
| use Opencast\OpencastController; | |||
There was a problem hiding this comment.
The changes in this file need to be reverted
Comment on lines
+109
to
+113
|
|
||
| public function decodeVars() | ||
| { | ||
| return base64_encode(json_encode(get_object_vars($this))); | ||
| } |
There was a problem hiding this comment.
Suggested change
| public function decodeVars() | |
| { | |
| return base64_encode(json_encode(get_object_vars($this))); | |
| } |
| @@ -0,0 +1,137 @@ | |||
| <?php | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1321,
The goal is to increase the query performance and decrease the video listing time in workspace and course / playlist.
Introduces:
As initial stage, it is considered as a proof of concept and might receive changes afterwards